Skip to content

RH-Virt package security review - #77

Merged
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt-security-review
May 6, 2026
Merged

RH-Virt package security review#77
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt-security-review

Conversation

@r2dedios

@r2dedios r2dedios commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-virt
  • rh-ai-engineer
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@r2dedios r2dedios self-assigned this May 5, 2026
@r2dedios r2dedios added the enhancement New feature or request label May 5, 2026
@r2dedios

r2dedios commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

WIP

@r2dedios r2dedios changed the title chore(rh-virt): Fixing yaml injection in vm-snapshot-create RH-Virt package security review May 6, 2026
@r2dedios r2dedios linked an issue May 6, 2026 that may be closed by this pull request
@r2dedios
r2dedios force-pushed the rh-virt-security-review branch from 56a4a3a to f7c51ec Compare May 6, 2026 15:48
@dmartinol
dmartinol merged commit 108febb into RHEcosystemAppEng:main May 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address security scanner findings in ocp-admin and rh-virt skills

2 participants