CODING_CONVENTIONS: add Section on Conditional Compilation #21950
+111
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
Dec 11, 2025
maribu
added
Type: enhancement
github-actions
bot
added
the
Process: missing approvals
maribu
requested review from
AnnsAnns,
benpicco,
crasbe,
mguetschow and
miri64
crasbe
requested changes
Dec 11, 2025
benpicco
reviewed
Dec 11, 2025
benpicco
reviewed
Dec 11, 2025
mguetschow
requested changes
Dec 11, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks for your write-up, much appreciated!
benpicco
approved these changes
Dec 11, 2025
crasbe
approved these changes
Dec 11, 2025
crasbe
removed
the
Process: missing approvals
mguetschow
approved these changes
Dec 12, 2025
Contributor
|
Please squash 🎾 |
elenaf9
force-pushed
the
coding-conventions/cond-compilation
branch
from
07509e5 to
7283bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Adds a section about the conventions for conditional compilation.
Based on a discussion yesterday on Matrix. Lmk if I understood everything correctly.
cc @benpicco @maribu @mguetschow