gcoap: adapt to API change in [PR20900] #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
While [PR20900] provides a compatibility .hdr accessor through a union, that trick is not available through bindgen or c2rust, which all introduce a dummy-named field for the anonymous union. Instead, we follow the path set out by [PR79] and introspect the source file. [PR20900]: RIOT-OS/RIOT#20900 [PR79]: #79 Co-Authored-By: Marian Buschsieweke <[email protected]>
This was referenced Oct 17, 2024
|
Thx! This would work. I split out the relevant API change into RIOT-OS/RIOT#20918. I'd like to have RIOT-OS/RIOT#20918 in first, not that there is some bike-shedding on the naming or so that would render this PR obsolete. |
|
Thanks, merged. If RIOT-OS/RIOT#20918 can indeed go in for the 2024.10 release, the workaround with two code paths could be very short lived :-) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While PR20900 provides a compatibility .hdr accessor through a union, that trick is not available through bindgen or c2rust, which all introduce a dummy-named field for the anonymous union. Instead, we follow the path set out by PR79 and introspect the source file.
Replaces and thus closes: #129
@maribu, please verify that this aligns with PR20900.