Pylint alerts corrections as part of an intervention experiment 1853 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a readable line shorter.
Made too line shorter. One was not readable.
Made a readable line shorter
Made unreadable commented out line shorter.
Made a readable line shorter
Made a readable line shorter
Made a readable line shorter
Made a readable line shorter
Made a readable line shorter
Made a readable line shorter
Made a readable line shorter
unneeded pass in the end of exception handling
Catching Exception might hide unexpected exceptions (e.g., due to new code that will be added). More than that, the exception handling does not log it but returns None, making it harder to detect. I changed it to catching requests.exceptions.HTTPError See https://stackoverflow.com/questions/24518944/try-except-when-using-python-requests-module
Catching Exception might hide unexpected exceptions (e.g., due to new code that will be added). The method parse calls R2DTResultInfo.validate (in line 96).Validate is a sequence of assertions, hence the specific AssertionError can be used instead. See https://stackoverflow.com/questions/1569049/making-pythons-assert-throw-an-exception-that-i-choose
…caught Catching Exception might hide unexpected exceptions (e.g., due to new code that will be added). The function ftp calls ftplib.FTP's quit (in line 40). The specific ftplib.all_errors can be used instead. See https://docs.python.org/3/library/ftplib.html
The function fallback calls fetch.lookup (in line 41). I changed to (fetch.UnknownReference, fetch.TooManyPublications) as discussed. Please note that I could not find where TooManyPublications is defined
As discussed, narrowed Exception to ValueError
|
' Thanks for your contribution to RNAcentral. I'''ve take a look over the changes and I think they are fine. I'''m a little worried about the formatting changes. Generally we use black to format things, which may end up conflicting with these changes. I will approve them even if they later get changed again. I think pylint also formatted some comments and docstrings which would also be useful. The exception handling also seems fine, so we can go ahead with this change.' |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the interventions describe in intervention issue.
The experiment is described here.
Each intervention was done in a dedicated commit with a message explaining it.
As we discussed, I created first a PR with the minor simple alerts:mline-too-long, unnecessary-pass, and broad-exception-caught.
I hope that the review will be easy.