Skip to content

Commit 47d01f8

Browse files
committed
* Fixes : DynamixelSDK ROS Indigo Issue - target_sources func in CMake
1 parent 2696547 commit 47d01f8

File tree

3 files changed

+24
-17
lines changed

3 files changed

+24
-17
lines changed

ReleaseNote.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- ..2017
66

77
* Added : Deprecated is now being shown by attributes #67 #107
8+
* Fixes : DynamixelSDK ROS Indigo Issue - target_sources func in CMake
89
* Fixes : Bug in protocol1_packet_handler.cpp, line 222 checking the returned Error Mask #120
910
* Fixes : Packet Handlers - array param uint8_t to uint16_t to avoid closure loop when the packet is too long to be in uint8_t appropriately
1011
* Fixes : Group Syncwrite using multiple ports in c library issue solved (test code is also in this issue bulletin) #124

c++/CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Changelog for package dynamixel_sdk
55
3.5.4 (2017--)
66
-----------
77
* Added : Deprecated is now being shown by attributes #67 #107
8+
* Fixes : DynamixelSDK ROS Indigo Issue - target_sources func in CMake
89
* Fixes : Bug in protocol1_packet_handler.cpp, line 222 checking the returned Error Mask #120
910
* Fixes : Packet Handlers - array param uint8_t to uint16_t to avoid closure loop when the packet is too long to be in uint8_t appropriately
1011
* Fixes : Group Syncwrite using multiple ports in c library issue solved (test code is also in this issue bulletin) #124

c++/CMakeLists.txt

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,30 @@ include_directories(
3535
${catkin_INCLUDE_DIRS}
3636
)
3737

38-
add_library(dynamixel_sdk
39-
src/dynamixel_sdk/packet_handler.cpp
40-
src/dynamixel_sdk/protocol1_packet_handler.cpp
41-
src/dynamixel_sdk/protocol2_packet_handler.cpp
42-
src/dynamixel_sdk/group_sync_read.cpp
43-
src/dynamixel_sdk/group_sync_write.cpp
44-
src/dynamixel_sdk/group_bulk_read.cpp
45-
src/dynamixel_sdk/group_bulk_write.cpp
46-
src/dynamixel_sdk/port_handler.cpp
47-
)
48-
4938
if(APPLE)
50-
target_sources(dynamixel_sdk PRIVATE src/dynamixel_sdk/port_handler_mac.cpp)
39+
add_library(dynamixel_sdk
40+
src/dynamixel_sdk/packet_handler.cpp
41+
src/dynamixel_sdk/protocol1_packet_handler.cpp
42+
src/dynamixel_sdk/protocol2_packet_handler.cpp
43+
src/dynamixel_sdk/group_sync_read.cpp
44+
src/dynamixel_sdk/group_sync_write.cpp
45+
src/dynamixel_sdk/group_bulk_read.cpp
46+
src/dynamixel_sdk/group_bulk_write.cpp
47+
src/dynamixel_sdk/port_handler.cpp
48+
src/dynamixel_sdk/port_handler_mac.cpp
49+
)
5150
else()
52-
if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
53-
set_property(TARGET dynamixel_sdk APPEND PROPERTY SOURCES src/dynamixel_sdk/port_handler_linux.cpp)
54-
else()
55-
target_sources(dynamixel_sdk PRIVATE src/dynamixel_sdk/port_handler_linux.cpp)
56-
endif()
51+
add_library(dynamixel_sdk
52+
src/dynamixel_sdk/packet_handler.cpp
53+
src/dynamixel_sdk/protocol1_packet_handler.cpp
54+
src/dynamixel_sdk/protocol2_packet_handler.cpp
55+
src/dynamixel_sdk/group_sync_read.cpp
56+
src/dynamixel_sdk/group_sync_write.cpp
57+
src/dynamixel_sdk/group_bulk_read.cpp
58+
src/dynamixel_sdk/group_bulk_write.cpp
59+
src/dynamixel_sdk/port_handler.cpp
60+
src/dynamixel_sdk/port_handler_linux.cpp
61+
)
5762
endif()
5863

5964
add_dependencies(dynamixel_sdk ${${PROJECT_NAME}_EXPORTED_TARGETS} ${catkin_EXPORTED_TARGETS})

0 commit comments

Comments
 (0)