-
Notifications
You must be signed in to change notification settings - Fork 128
[TRITON] Benchmarking improvements #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eky-amd
wants to merge
32
commits into
main
Choose a base branch
from
eky/triton-bench-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins CI skipped: Check lint failed. Exiting the entire job... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<Provider>_<Layer>_<Metric>_(<Unit>)). Provider describes whether the bench was performed using the Triton kernel or Torch functions. Layer is eitherfc1orfc2for model benchmarks. Both are optional. Metric is either time (ms), throughput (TFLOPS), or bandwidth (GB/s).arch_infoandget_splitkimport issues intriton/bench_batched_gemm_afp4wfp4.py,triton/bench_batched_gemm_afp4wfp4_pre_quant.pyandtriton/bench_gemm_a8wfp4.py.STR_DTYPE_TO_TORCH_DTYPEimport issue intriton/bench_pa_prefill.py.-bench_torchflag.op_tests/op_benchmarks/triton/utils/model_configs.json(removing MoE parameters from llama models, changing top_k parameter from 4 to 8 in deepseek-v3).op_tests/op_benchmarks/triton/bench_schema.yaml.Testing
Manuel tests were performed on both MI300 and MI350, across both shape and model benchmarks. Please see these metrics for fixed shape parameters, comparing the Triton kernels and PyTorch. Below are some sample outputs, from running
triton/bench_gemm_a8w8_blockscale.pywith llama3-8B.Before:


After:
Triton vs Torch:

Below is a sample run of


op_tests/op_benchmarks/triton/bench_moe.py, using the new gptoss model family.Compared with deepseek-V3:
Attempting to benchmark MoE with the llama3 family of models now accurately throws an error.
