Fix rowwise a8w8 gemm in swizzled hipb_mm #1258
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the incorrectly configured matA/B scales of
hipb_mmin B-preshuffled, row-wise FP8 mode.It uses the
HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32Fenum introduced since hipblaslt >= 1.0.0 to set scale mode, so in compilation in guards hipblaslt versions and raises runtime errors for incompatible hipblaslt versions.Technical Details
Test Plan
Unit test in op_tests/test_gemm_a8w8.py on MI300X
python op_tests/test_gemm_a8w8.py -d bf16 -q fp8Test Result
Before fix
After the fix
Submission Checklist