Fix HIP graph launch and runtime edge semantics#155
Open
AWoloszyn wants to merge 3 commits into
Open
Conversation
Allow no-argument native HIP kernel launches to be represented consistently across graph and direct stream paths when host stubs provide an empty args-array. Non-empty args-array launches without parameter metadata still fail explicitly instead of inventing an ABI layout. Tighten graph memcpy and runtime pointer semantics around pooled logical allocation sizes, zero-byte allocation behavior, host-pointer attributes, worker-thread stream copies, event barriers, host-visible allocation backing, and native argument ABI offsets.
zjgarvey
reviewed
Jun 30, 2026
zjgarvey
left a comment
Collaborator
There was a problem hiding this comment.
Looking at some other callers for iree_hip_validate_memcpy_ranges, I noticed that the hipMemcpy and hipMemcpyAsync pass false for use_hip_visible_pool_size, and wasn't sure if those direct stream paths should use this logical size bound, too.
Collaborator
Author
|
Thanks, these were valid cleanups. I added follow-up commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow no-argument native HIP kernel launches to be represented consistently across graph and direct stream paths when host stubs provide an empty args-array. Non-empty args-array launches without parameter metadata still fail explicitly instead of inventing an ABI layout.
Tighten graph memcpy and runtime pointer semantics around pooled logical allocation sizes, zero-byte allocation behavior, host-pointer attributes, worker-thread stream copies, event barriers, host-visible allocation backing, and native argument ABI offsets.