Fix topology storage max alignment#159
Open
jtuyls wants to merge 1 commit into
Open
Conversation
iree_max_align_t is already the numeric maximum host alignment value, not a type. Passing iree_alignof(iree_max_align_t) asks for the alignment of the expression produced by that value, which is conceptually the wrong operation even on compilers that accept it. Pass iree_max_align_t directly to iree_host_align so the topology storage layout is padded to the intended maximum host alignment. On MSVC the old expression expands to __alignof(16) and fails with: topology_builder.c(66): error C2059: syntax error: 'constant'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iree_max_align_t is already the numeric maximum host alignment value, not a type. Passing iree_alignof(iree_max_align_t) asks for the alignment of the expression produced by that value, which is conceptually the wrong operation even on compilers that accept it.
Pass iree_max_align_t directly to iree_host_align so the topology storage layout is padded to the intended maximum host alignment.
On MSVC the old expression expands to __alignof(16) and fails with: topology_builder.c(66): error C2059: syntax error: 'constant'.