Skip to content

[WIP][Testing][Flang][OpenMP] Initial implementation of ref_ptr/ptee/ptr_ptee and attach auto/always/never #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: amd-staging
Choose a base branch
from
+785 −343
Open

[WIP][Testing][Flang][OpenMP] Initial implementation of ref_ptr/ptee/ptr_ptee and attach auto/always/never #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2af3ef4
WIP ref_* map type
agozillon Nov 3, 2025
20442b8
Tidy things up a bit more
agozillon Nov 8, 2025
90b822c
Fix bug, apparently attach on exiting map directives are still required.
agozillon Nov 8, 2025
938bf1f
Re-add some of the exit directive attach map stuff for the moment as …
agozillon Nov 8, 2025
64092a7
[Flang] Fix defaultmap(none) being overly aggressive with symbol checks
agozillon Nov 12, 2025
f5d1644
[Flang][OpenMP] WIP attach auto/never/always implementation
agozillon Nov 13, 2025
70d7792
Revert "[Flang] Fix defaultmap(none) being overly aggressive with sym…
agozillon Nov 13, 2025
e0e92cd
WIP ref_ptr_ptee attach clause work
agozillon Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions flang/lib/Lower/OpenMP/ClauseProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,8 +1311,6 @@ bool ClauseProcessor::processMap(
mlir::Location clauseLocation = converter.genLocation(source);
const auto &[mapType, typeMods, attachMod, refMod, mappers, iterator,
objects] = clause.t;
if (attachMod)
TODO(currentLocation, "ATTACH modifier is not implemented yet");
mlir::omp::ClauseMapFlags mapTypeBits = mlir::omp::ClauseMapFlags::none;
std::string mapperIdName = "__implicit_mapper";
// If the map type is specified, then process it else set the appropriate
Expand Down Expand Up @@ -1357,6 +1355,34 @@ bool ClauseProcessor::processMap(
mapTypeBits |= mlir::omp::ClauseMapFlags::ompx_hold;
}

if (refMod) {
switch (*refMod) {
case Map::RefModifier::RefPtee:
mapTypeBits |= mlir::omp::ClauseMapFlags::ref_ptee;
break;
case Map::RefModifier::RefPtr:
mapTypeBits |= mlir::omp::ClauseMapFlags::ref_ptr;
break;
case Map::RefModifier::RefPtrPtee:
mapTypeBits |= mlir::omp::ClauseMapFlags::ref_ptr_ptee;
break;
}
}

if (attachMod) {
switch (*attachMod) {
case Map::AttachModifier::Always:
mapTypeBits |= mlir::omp::ClauseMapFlags::attach_always;
break;
case Map::AttachModifier::Never:
mapTypeBits |= mlir::omp::ClauseMapFlags::attach_never;
break;
case Map::AttachModifier::Auto:
mapTypeBits |= mlir::omp::ClauseMapFlags::attach_auto;
break;
}
}

if (iterator) {
TODO(currentLocation,
"Support for iterator modifiers is not implemented yet");
Expand Down
1 change: 1 addition & 0 deletions flang/lib/Optimizer/OpenMP/AutomapToTargetData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ class AutomapToTargetDataPass
builder.getAttr<omp::VariableCaptureKindAttr>(
omp::VariableCaptureKind::ByCopy),
/*var_ptr_ptr=*/mlir::Value{},
/*var_ptr_ptr_type=*/mlir::TypeAttr{},
/*members=*/SmallVector<Value>{},
/*members_index=*/ArrayAttr{}, bounds,
/*mapperId=*/mlir::FlatSymbolRefAttr(), globalOp.getSymNameAttr(),
Expand Down
1 change: 1 addition & 0 deletions flang/lib/Optimizer/OpenMP/LowerWorkdistribute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@ static TempOmpVar allocateTempOmpVar(Location loc, Type ty,
rewriter.getAttr<omp::VariableCaptureKindAttr>(
omp::VariableCaptureKind::ByRef),
/*varPtrPtr=*/Value{},
/*varPtrPtrType=*/mlir::TypeAttr{},
/*members=*/SmallVector<Value>{},
/*member_index=*/mlir::ArrayAttr{},
/*bounds=*/ValueRange(),
Expand Down
Loading