test(miopen): add ffm-quick test filter (ROCM-20705)#9351
Open
SreecharanGundaboluAMD wants to merge 2 commits into
Open
test(miopen): add ffm-quick test filter (ROCM-20705)#9351SreecharanGundaboluAMD wants to merge 2 commits into
SreecharanGundaboluAMD wants to merge 2 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
SreecharanGundaboluAMD
changed the title
randyspauldingamd
approved these changes
Jul 13, 2026
randyspauldingamd
left a comment
randyspauldingamd
left a comment
Contributor
There was a problem hiding this comment.
Several patterns are included, but then excluded verbatim. This makes them look like typos, and we should clarify the intent. I'll mark it Approved to reduce iteration though.
A few options are:
- More generic wildcards where appropriate:
# in test_patterns:
"Smoke/GPU_reference_kernel_fwd_3d_NCDHW_"
# in exclude:
"Smoke/GPU_reference_kernel_fwd_3d_NCDHW_BFP16_BFP16*" # ...
2a. delete both if they're all not to be ran.
2b. If you wanted to emphasize "do not run this", it would be fine to leave the excluded mention (with a comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : ROCM-20705
Motivation
This PR introduces a ffm-quick test category for FFM testing. We will expand FFM test coverage gradually.
Technical Details
test_categories.yaml — two changes:
New ffm-quick category added and is labelled for both ffm-quick and ffm-full dispatch. Timeout set to 7200 s (2 h)`.
Risk Assessment
Risk Level: 🟢 Low
Impacted Components
projects/miopen/test/gtest/test_categories.yaml — CI category definitions
Mitigation Steps
Changes are test-only; no kernel, solver, or library logic is touched.
Test Plan
The ffm-quick category will be validated by manually triggering it using github actions.
Test Result
-[x] Validate that the PR automatically picks up and runs the quick filter in this PR.
Submission Checklist