Skip to content

test(rocke): Revert rocke ir parity harness for attention (#9267)#9354

Merged
brockhargreaves-amd merged 1 commit into
developfrom
revert-9267-users/barkocot/aick-1621
Jul 14, 2026
Merged

test(rocke): Revert rocke ir parity harness for attention (#9267)#9354
brockhargreaves-amd merged 1 commit into
developfrom
revert-9267-users/barkocot/aick-1621

Conversation

@brockhargreaves-amd

@brockhargreaves-amd brockhargreaves-amd commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 1e30ce1.

Motivation

PR #9267 added attention IR cases to the golden byte-stability gate (rocke_representative_ir_sha256.json) and extended the parity harness. The golden was blessed against a specific LLVM flavor/build, but the
hashes do not match on current develop builds — causing test_ir_cases_match_golden_sha256 to fail in CI and locally. This blocks the rocKE pytest suite gate (which runs as part of the hipkernelprovider test artifact) from passing cleanly.

Technical Details

Reverts all three file changes from #9267:

  • rocke_representative_ir_sha256.json — removes the 238 new attention
    IR entries that do not match current builds
  • rocke_ir_parity_harness.py — removes the attention harness extension
  • test_feature_parity.py — restores the removed line

The attention IR parity gate can be re-landed once the golden is blessed against the current LLVM toolchain and verified green in CI.

Test Plan

  • Verified test_ir_cases_match_golden_sha256 passes after revert (locally on Windows gfx1151 and in CI on Linux gfx942)

Test Result

Before revert: test_ir_cases_match_golden_sha256 FAILED (IR drift on attention entries).
After revert: all test_rocke_ci_static tests pass.

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@brockhargreaves-amd brockhargreaves-amd changed the title Revert "test(rocke): rocke ir parity harness for attention (#9267)" test(rocke): Revert rocke ir parity harness for attention (#9267) Jul 13, 2026
@brockhargreaves-amd brockhargreaves-amd enabled auto-merge (squash) July 13, 2026 22:54
@brockhargreaves-amd brockhargreaves-amd merged commit 6ae94a9 into develop Jul 14, 2026
33 of 39 checks passed
@brockhargreaves-amd brockhargreaves-amd deleted the revert-9267-users/barkocot/aick-1621 branch July 14, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants