test(rocke): Revert rocke ir parity harness for attention (#9267)#9354
Merged
brockhargreaves-amd merged 1 commit intoJul 14, 2026
Merged
Conversation
This reverts commit 1e30ce1.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
yraparti
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1e30ce1.
Motivation
PR #9267 added attention IR cases to the golden byte-stability gate (
rocke_representative_ir_sha256.json) and extended the parity harness. The golden was blessed against a specific LLVM flavor/build, but thehashes do not match on current develop builds — causing
test_ir_cases_match_golden_sha256to fail in CI and locally. This blocks the rocKE pytest suite gate (which runs as part of the hipkernelprovider test artifact) from passing cleanly.Technical Details
Reverts all three file changes from #9267:
rocke_representative_ir_sha256.json— removes the 238 new attentionIR entries that do not match current builds
rocke_ir_parity_harness.py— removes the attention harness extensiontest_feature_parity.py— restores the removed lineThe attention IR parity gate can be re-landed once the golden is blessed against the current LLVM toolchain and verified green in CI.
Test Plan
test_ir_cases_match_golden_sha256passes after revert (locally on Windows gfx1151 and in CI on Linux gfx942)Test Result
Before revert:
test_ir_cases_match_golden_sha256FAILED (IR drift on attention entries).After revert: all
test_rocke_ci_statictests pass.Submission Checklist