Skip to content

feat(rocBLAS): add FFM test sets#9376

Open
TorreZuk wants to merge 1 commit into
developfrom
users/torrezuk/airocblas-1269-revise-filters
Open

feat(rocBLAS): add FFM test sets#9376
TorreZuk wants to merge 1 commit into
developfrom
users/torrezuk/airocblas-1269-revise-filters

Conversation

@TorreZuk

@TorreZuk TorreZuk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Motivation

This pull request introduces new FFM test categories and integrates them into the test configuration for both hipBLAS and rocBLAS projects. The main goal is to support FFM pipelines, with specific timeouts and test patterns, as well as to update the XML test runner configuration. The most important changes are summarized below.

Test category additions and configuration:

  • Added new ffm-quick and ffm-full test categories to both hipblas and rocblas test_categories.yaml files, including descriptions, test patterns, exclusions, and labels for each category. These are intended for FFM runs.

  • Set category-specific timeouts for ffm-quick and ffm-full (2 hours each) in the execution_settings sections of both projects to enforce FFM runner time budgets.

rocBLAS test runner and category updates:

  • Updated rocblas test categories to indicate that the rtest-driver is enabled, which means test patterns and exclusions are not used for most categories. Also added *known_bug* as a placeholder pattern and exclusion for consistency.

Test runner integration:

  • Updated rocblas/rtest.xml to define new test sets for ctest_ffm-quick and ctest_ffm-full, specifying the corresponding YAML files and filters to be used during the test runs.

JIRA ID: AIROCBLAS-1269

@TorreZuk

Copy link
Copy Markdown
Contributor Author

@JeniferC99 this closely matches your PR for hipblas, still not clear if runner for hipblas is desired but test sets can added as if ignored are fine. rocblas now uses rtest-driver so xml file driven runs

@TorreZuk TorreZuk changed the title feat(rocBLAS) add FFM test sets feat(rocBLAS): add FFM test sets Jul 13, 2026
@ROCm ROCm deleted a comment from therock-pr-bot Bot Jul 13, 2026
@ROCm ROCm deleted a comment from therock-pr-bot Bot Jul 13, 2026
Comment thread projects/rocblas/clients/gtest/test_categories.yaml
@ROCm ROCm deleted a comment from therock-pr-bot Bot Jul 13, 2026
@ROCm ROCm deleted a comment from therock-pr-bot Bot Jul 13, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@evedovelli evedovelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.84%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9376      +/-   ##
===========================================
- Coverage    64.69%   64.68%   -0.01%     
===========================================
  Files         2685     2685              
  Lines       422637   422637              
  Branches     62808    62808              
===========================================
- Hits        273416   273376      -40     
- Misses      128551   128593      +42     
+ Partials     20670    20668       -2     
Flag Coverage Δ *Carryforward flag
TensileLite 35.05% <ø> (ø) Carriedforward from 13d842a
hipBLAS 90.62% <ø> (-0.19%) ⬇️
hipBLASLt 34.69% <ø> (ø) Carriedforward from 13d842a
hipCUB 82.68% <ø> (ø) Carriedforward from 13d842a
hipDNN 86.03% <ø> (ø) Carriedforward from 13d842a
hipFFT 50.88% <ø> (ø) Carriedforward from 13d842a
hipRAND 76.12% <ø> (ø) Carriedforward from 13d842a
hipSOLVER 69.18% <ø> (ø) Carriedforward from 13d842a
hipSPARSE 86.10% <ø> (ø) Carriedforward from 13d842a
rocBLAS 47.92% <ø> (ø)
rocFFT 46.82% <ø> (ø) Carriedforward from 13d842a
rocRAND 57.03% <ø> (ø) Carriedforward from 13d842a
rocSOLVER 76.84% <ø> (ø) Carriedforward from 13d842a
rocSPARSE 72.37% <ø> (ø) Carriedforward from 13d842a
rocThrust 91.36% <ø> (ø) Carriedforward from 13d842a

*This pull request uses carry forward flags. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TorreZuk

Copy link
Copy Markdown
Contributor Author

@JeniferC99 can you review, and what is your co_author string for me to add on merge?
I thought I asked github to add a dropdown feature for this but can't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants