Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-443, FAU-444] Make “German language skills for international students” taxonomy hierarchical #20

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-443
https://inpsyde.atlassian.net/browse/FAU-444

Discussion: https://inpsyde.slack.com/archives/C045KFJ9MB5/p1734520808952019

What is the new behavior (if this is a feature change)?

  • German language skills for international students taxonomy is hierarchical
  • MultilingualLink has been extended with a parent property to enable proper synchronization of both child and parent terms to consuming websites

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Related PR that incorporates the use of parent property for synchronization to consuming websites: RRZE-Webteam/FAU-Studium-Embed#49

@zhyian zhyian marked this pull request as ready for review December 18, 2024 15:18
@zhyian zhyian requested review from shvlv, amiut and o-samaras December 18, 2024 15:18
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM. Thanks

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of it

@zhyian zhyian marked this pull request as draft December 23, 2024 08:59
Copy link
Contributor

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on that!

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@zhyian zhyian merged commit 9d164cf into main Jan 3, 2025
8 checks passed
@zhyian zhyian deleted the FAU-443 branch January 3, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants