-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAU-443, FAU-444] Make “German language skills for international students” taxonomy hierarchical #20
Conversation
…for international students' filter and column, if exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on that!
src/Infrastructure/Repository/WordPressDatabaseDegreeProgramRepository.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-443
https://inpsyde.atlassian.net/browse/FAU-444
Discussion: https://inpsyde.slack.com/archives/C045KFJ9MB5/p1734520808952019
What is the new behavior (if this is a feature change)?
German language skills for international students
taxonomy is hierarchicalMultilingualLink
has been extended with aparent
property to enable proper synchronization of both child and parent terms to consuming websitesDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Related PR that incorporates the use of
parent
property for synchronization to consuming websites: RRZE-Webteam/FAU-Studium-Embed#49