Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-452] Introduce 'linkWithLang' method #23

Merged
merged 2 commits into from
Mar 5, 2025
Merged

[FAU-452] Introduce 'linkWithLang' method #23

merged 2 commits into from
Mar 5, 2025

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Feb 28, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-452

What is the new behavior (if this is a feature change)?
The new linkWithLang method returns the single degree program URL with the lang parameter.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
PR where this method is used.

@zhyian zhyian requested a review from tyrann0us March 4, 2025 09:22
Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks! I didn't know is_locale_switched(). 💪🏽

@zhyian zhyian merged commit c58b181 into main Mar 5, 2025
8 checks passed
@zhyian zhyian deleted the FAU-452 branch March 5, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants