Skip to content

bsp/nxp:Separate NXP_MCX drivers #10246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented May 7, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

将NXP_MCX的sdk库分离成软件包

需要软件包索引那边合并后才能测ci

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@hydevcode hydevcode requested a review from Rbb666 as a code owner May 7, 2025 05:51
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels May 7, 2025
@hydevcode hydevcode marked this pull request as draft May 7, 2025 05:58
@hydevcode hydevcode marked this pull request as ready for review May 7, 2025 07:04
@hydevcode hydevcode closed this May 7, 2025
@hydevcode hydevcode reopened this May 7, 2025
@hydevcode hydevcode marked this pull request as draft May 7, 2025 08:06
@supperthomas
Copy link
Member

这个建议5.11号之后再合。

@hydevcode hydevcode force-pushed the nxp_mcx branch 2 times, most recently from 7b689ce to 6f2e423 Compare May 7, 2025 09:22
@hydevcode hydevcode marked this pull request as ready for review May 7, 2025 09:32
@hydevcode hydevcode marked this pull request as draft May 7, 2025 09:32
@supperthomas
Copy link
Member

@imi415

@supperthomas supperthomas marked this pull request as ready for review May 11, 2025 08:44
@supperthomas
Copy link
Member

https://github.com/hydevcode/rt-thread/blob/6f2e4237ba34fcc2b7f0a8f724b6a9a4b05b06a4/bsp/nxp/mcx/tools/sdk_dist.py#L12-L19

这里参考stm32 修复一下,执行scons --dist 估计会有问题。

另外readme里面,要加一些说明,明确告知需要pkgs --update

@hydevcode hydevcode closed this May 12, 2025
@hydevcode hydevcode reopened this May 12, 2025
@hydevcode hydevcode closed this May 12, 2025
@hydevcode hydevcode reopened this May 12, 2025
Copy link

📌 Code Review Assignment


📊 Current Review Status (Last Updated: 2025-05-12 02:42 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@hydevcode
Copy link
Contributor Author

https://github.com/hydevcode/rt-thread/blob/6f2e4237ba34fcc2b7f0a8f724b6a9a4b05b06a4/bsp/nxp/mcx/tools/sdk_dist.py#L12-L19

这里参考stm32 修复一下,执行scons --dist 估计会有问题。

另外readme里面,要加一些说明,明确告知需要pkgs --update

ok

@supperthomas supperthomas merged commit 27430ca into RT-Thread:master May 12, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: NXP Code related with NXP BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants