Skip to content

bsp:stm32:Add reminder for missing dependency packages #10247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

fengmuyou
Copy link
Contributor

…ate'

拉取/合并请求描述:(PR description)

[
ps:为stm32系列添加 依赖包缺失的提醒,在没有下载依赖包的情况下 编译时提醒用户执行 'pkgs --update' 。

请在这里填写您的PR描述,可以包括以下之一的内容:为什么提交这份PR;解决的问题是什么,你的解决方案是什么;
Please fill in your PR description here, which can include one of the following items: why to submit this PR; what is the problem solved and what is your solution;

并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested. -->

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@fengmuyou fengmuyou marked this pull request as draft May 7, 2025 10:11
@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels May 7, 2025
@fengmuyou fengmuyou closed this May 9, 2025
@fengmuyou fengmuyou reopened this May 9, 2025
@fengmuyou fengmuyou closed this May 12, 2025
@fengmuyou fengmuyou reopened this May 12, 2025
@fengmuyou fengmuyou closed this May 12, 2025
@fengmuyou fengmuyou reopened this May 12, 2025
Copy link

github-actions bot commented May 12, 2025

📌 Code Review Assignment

🏷️ Tag: stm32f407-rt-spark

Path: bsp/stm32/stm32f407-rt-spark
Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/SConstruct

📊 Current Review Status (Last Updated: 2025-05-12 05:32 UTC)

  • Rbb666 Reviewed On 2025-05-12 05:28 UTC
  • kurisaW Reviewed On 2025-05-12 05:24 UTC

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@fengmuyou fengmuyou marked this pull request as ready for review May 12, 2025 05:22
@kurisaW
Copy link
Contributor

kurisaW commented May 12, 2025

lgtm

@Rbb666
Copy link
Member

Rbb666 commented May 12, 2025

lgtm

@Rbb666 Rbb666 merged commit 0a57f0a into RT-Thread:master May 12, 2025
154 of 157 checks passed
@fengmuyou fengmuyou deleted the stm32_sdk branch May 12, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants