Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

164 adding multientity to tutorials #260

Merged
merged 29 commits into from
Apr 26, 2024
Merged

Conversation

RCX112
Copy link
Collaborator

@RCX112 RCX112 commented Mar 12, 2024

closes #164

@RCX112 RCX112 requested a review from djs0109 March 12, 2024 15:02
@RCX112
Copy link
Collaborator Author

RCX112 commented Apr 4, 2024

@djs0109 I also added an example of a timestamp attribute, which uses the JEXL function 'toisodate'.

@RCX112
Copy link
Collaborator Author

RCX112 commented Apr 12, 2024

@djs0109 The documentation of the iotagent-node-lib says, that the legacy expression language is deprecated since 3.2.0 and they only use JEXL (https://iotagent-node-lib.readthedocs.io/en/3.4.0/deprecated.html). Should we therefore remove old functionalities of the expression languages in filip?

@djs0109
Copy link
Contributor

djs0109 commented Apr 12, 2024

@RCX112 nice hint! I think we can first add a deprecation warning for the attribute expressionLanguage in service group. We should also keep in mind that, the expression validator must also be adjusted accordingly. For example, if expression of legacy format is detected, a warning/error will be given

@djs0109
Copy link
Contributor

djs0109 commented Apr 16, 2024

@RCX112 could you merge the #165 to this branch? Because they are highly related with each other

@RCX112 RCX112 requested a review from djs0109 April 23, 2024 14:06
@RCX112
Copy link
Collaborator Author

RCX112 commented Apr 23, 2024

@djs0109 I added some tests for the expression languages and I also put the pyjexl package in the requirements

# Exercise 8: MultiEntity and Expression Language

The MultiEntity plugin Allows the devices provisioned in the IoTAgent to map their attributes to more than one entity,
declaring the target entity through the Configuration or Device provisioning APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "Configuration" APIs?

@djs0109
Copy link
Contributor

djs0109 commented Apr 24, 2024

@RCX112 Thank you! It looks really great. I only changed a little in the tutorials

@RCX112 RCX112 merged commit 3dff267 into master Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding multientity to tutorials
2 participants