Add DRB4 to parameters.json #128
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for (closed) issue #60 . Added DRB4 to preferences.json file to include DRB4 as one of the default loci extracted/genotyped. Rationale is that DRB4 has similar frequency/diversity to DRB3 or DRB5, which are already included (https://hla.alleles.org/data/refs/drb4_refs.html).
Attaching a zip file to this request with
test.bamandtest.bam.baifiles that add synthetic DRB4 reads to the test files from the repo. Opted not to update tests files inside the repo itself since validating DRB4 specifically seems outside the intended use of those test files.drb4_test.zip