[pull] develop from duckduckgo:develop #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Task/Issue URL: https://app.asana.com/0/1205648422731273/1209011223549610/f ### Description In certain scenarios, the app makes unnecessary requests to api/subscriptions endpoint - this PR addresses that. More context in the linked task. ### Steps to test this PR See task. ### No UI changes
Task/Issue URL: https://app.asana.com/0/414730916066338/1209003600291441/f Re: https://app.asana.com/0/414730916066338/1209021936559905/f ### Description The assets for the dashboard were removed by mistake, this PR adds them back. Please see the link above for more details. ### Steps to test this PR - The dashboard loads correctly _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
…5402) Task/Issue URL: https://app.asana.com/0/1201807753394693/1209007672205184/f ### Description Update some subscriptions models in order to support free trials on mobile: - `SubscriptionOffer` model - `OptionsJson` model - `getSubscriptionOffer()` method ### Steps to test this PR _Pre steps_ - [x] Apply patch to being able to test subscriptions in staging _Privacy Pro Eligible US_ - [x] Make sure you are US eligible - [x] Install form branch - [x] Check browser works as expected - [x] Go to Settings - [x] Check you can see Privacy Pro option - [x] Tap on that option - [x] Check Subscription page looks as expected - [x] Purchase any of the options and check it works well - [x] Go to Subscription Settings - [x] Check everything works as expected _Privacy Pro Eligible ROW (Optional)_ - [x] Make sure you are ROW eligible - [x] Install form branch - [x] Check browser works as expected - [x] Go to Settings - [x] Check you can see Privacy Pro option - [x] Tap on that option - [x] Check Subscription page looks as expected - [x] Purchase any of the options and check it works well - [x] Go to Subscription Settings - [x] Check everything works as expected _Privacy Pro No Eligible_ - [x] Install form branch - [x] Check browser works as expected - [x] Go to Settings - [x] Check you can't see Privacy Pro option ### No UI changes Co-authored-by: Lukasz Macionczyk <[email protected]>
Task/Issue URL: https://app.asana.com/0/1209022585506290/1209022585506290 Autoconsent Release: https://github.com/duckduckgo/autoconsent/releases/tag/v12.4.0 ## Description Updates Autoconsent to version [v12.4.0](https://github.com/duckduckgo/autoconsent/releases/tag/v12.4.0). ### Autoconsent v12.4.0 release notes See release notes [here](https://github.com/duckduckgo/autoconsent/blob/v12.4.0/CHANGELOG.md) ## Steps to test This release has been tested during Autoconsent development. You can check the release notes for more information. 1. Make sure that there's no unexpected failures in CI checks 2. (optional) smoke test some of the sites mentioned in the release notes 3. If there are problems, reach out to a CPM DRI Co-authored-by: muodov <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1208870901574431/f ### Description All new translations for the Update Settings feature. --------- Co-authored-by: Dax The Translator <[email protected]>
…mpl.configuration.RealAutofillRuntimeConfigProvider.getRuntimeConfiguration (#5433) Task/Issue URL: https://app.asana.com/0/1200905986587319/1209069285792741/f ### Description Optimized string manipulation within getRuntimeConfiguration function. ### Steps to test this PR Smoke test for autofill. ### NO UI changes
Task/Issue URL: https://app.asana.com/0/1200905986587319/1209058892339948/f ### Description Fixed flaky test. `whenLocalDateNowThenReturnWeeklyCohort` should assert on week based year and not the year directly as this makes the expected value to be incorrect in edge-cases where the date is a date in a year and falls into a previous year week. I.e 2025-01-01. ### Steps to test this PR Note: PR Unit tests should pass as it was submitted the same day that caused the failure (2024-01-30). - [x] change `whenLocalDateNowThenReturnWeeklyCohort` date to be `LocalDate.of(2024, 1, 30)` - [x] verify test passes ### NO UI changes
…viewImage (#5432) Task/Issue URL: https://app.asana.com/0/488551667048375/1209069285792730/f ### Description Moved file operations to background. ### Steps to test this PR - [x] Install from this branch. - [x] Open many tabs and go to the Tab Switcher screen. - [x] Notice the tabs are loaded properly and the app doesn't freeze. ### NO UI changes
…ppear until background/foreground (#5427) Task/Issue URL: https://app.asana.com/0/715106103902962/1209003862601172/f ### Description Fixed scrolling issue on focused view. ### Steps to test this PR See task description for video https://app.asana.com/0/715106103902962/1209003862601172/f Steps to reproduce: - [x] Install from develop. - [x] Have Address Bar set to Top. - [x] On NTP use finger to hold/slide the address bar to the top of the device. - [x] Observe that you can not use any gesture to make the address bar reappear. Steps to test the fix: - [x] Install from this branch. - [x] Have Address Bar set to Top. - [x] On NTP use finger to hold/slide the address bar to the top of the device. - [x] Notice the Address Bar does not scroll. ### NO UI changes
Task/Issue URL: https://app.asana.com/0/488551667048375/1208893769470376/f ### Description Updates Anvil 2.5.0-beta11 to 2.5.0. ### Steps to test this PR - [ ] Smoke test
Task/Issue URL: https://app.asana.com/0/488551667048375/1209095880220827/f ----- - Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209069202192275 ### Description Update styleguide to match current state.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208880593716452/f ### Description Adds new pixels to Settings where we were missing some compared to iOS. See task for more details. ### Steps to test this PR Prerequisite: Enable `newSettings` feature toggle _Cookie Pop-Up Protection_ - [x] Open Cookie Pop-Up Protection screen - [x] Check `m_settings_autoconsent_shown` Pixel is fired - [x] Toggle pop-up protection off - [x] Check `m_settings_autoconsent_off` Pixel is fired - [x] Toggle pop-up protection on - [x] Check `m_settings_autoconsent_on` Pixel is fired _Next Steps: Address Bar Position_ - [x] From main Settings screen click "Set Your Address Bar Position" - [x] Check `m_settings_next_steps_set_address_bar` Pixel is fired _Next Steps: Enable Voice Search_ - [x] Use a Pixel device - [x] From main Settings screen click "Enable Voice Search" - [x] Check `m_settings_next_steps_enable_voice_search` Pixel is fired ### UI changes N/A
Task/Issue URL: https://app.asana.com/0/72649045549333/1209088941998966/f ### Description Migrates the UI tests to use Robin instead of Maestro-Cloud. ### Steps to test this PR - [x] Ensure the linked GHA actions all succeeded Test type | GHA link -- | -- release | https://github.com/duckduckgo/Android/actions/runs/12631524047 Design system (ADS) | https://github.com/duckduckgo/Android/actions/runs/12649848989 autofill | https://github.com/duckduckgo/Android/actions/runs/12631551742 custom tabs | https://github.com/duckduckgo/Android/actions/runs/12631564639 privacy dashboard | https://github.com/duckduckgo/Android/actions/runs/12641880859 Co-authored-by: Craig Russell <[email protected]>
Task/Issue URL: https://app.asana.com/0/488551667048375/1208996865644937/f ### Description Selectively clears entries from the `WebView`’s LevelDB. ### Steps to test this PR _Point at the JSON blob linked in the task_ - [x] Open AI Chat - [x] Type a prompt - [x] Go to `cnn.com` - [x] Use the fire button - [x] Verify that you see: ``` LocalStorageManager: Allowed domains: [duckduckgo.com] LocalStorageManager: Matching regex: [^_https://([a-zA-Z0-9.-]+\.)?{domain}\u0000\u0001.+$, ^META:https://([a-zA-Z0-9.-]+\.)?{domain}$, ^METAACCESS:https://([a-zA-Z0-9.-]+\.)?{domain}$] ``` - [x] Verify that the `cnn.com` entries are deleted (And any other sites you may have visited), e.g. ``` LocalStorageManager: Deleted key: _https://edition.cnn.com??xyz ``` - [x] Go back to AI Chat - [x] Verify that the recent chats are retained --------- Co-authored-by: Aitor Viana <[email protected]>
Task/Issue URL: https://app.asana.com/0/72649045549333/1208589862044960/f ### Description Removes the old code of the legacy omnibar. ### Steps to test this PR Stress test the Omnibar.
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203799615548207/f ### Description For a while we’ve been using a new palette of colors. The codebase however, was still referencing old colors. This PR fixes that.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209104445515863/f ----- - Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209098231830092/f ### Description ### Steps to test this PR Prerequisites: Enable `newSettings` feature flag _New DuckPlayer_ - [x] Open DuckPlayer - [x] Compare against [designs](https://www.figma.com/design/BOHDESHODUXK7wSRNBOHdu/%F0%9F%A4%96-Android-Components?node-id=13242-55598&t=SfOvJgmy0IYXDv1b-4) - [x] Click options and ensure they work - [x] To see disabled State ensure `DisabledWithHelpLink` is set as the ViewState in `DuckPlayerSettingsViewModel` _Old DuckPlayer_ - [x] Turn off `newSettings` feature flag - [x] Ensure the old settings screen shows - [x] Click options and ensure they work ### UI changes | Before | After | | ------ | ----- | || |||
Task/Issue URL: https://app.asana.com/0/1200156640058969/1209303556783952 ### Description Adds metrics around the autofill service ### Steps to test this PR Notice: specs are present in https://app.asana.com/0/1200156640058969/1209115687167237 Use `message~:"Pixel sent: autofill_"` as filter Test cases in https://app.asana.com/0/488551667048375/1209504798589773 ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/1205008441501016/1209426268774143 ### Description Process exceptions from RC and don't flag a site as malicious if domain matches an exception ### Steps to test this PR _Feature 1_ - [x] Load https://broken.third-party.site/security/badware/malware.html - [x] Check site isn't blocked - [x] Check logcat for _"should not block (exempted) broken.third-party.site"_ * Note: if this doesn't work, check the following: * Reinstall the app. Since exceptions were already present in the JSON but not parsed, there's a chance RC update logic hasn't triggered * Check https://staticcdn.duckduckgo.com/trackerblocking/config/v4/android-config.json and see if broken.third-party.site is still added as an exception to maliciousSiteProtection
…ownloading privacy config (#5683) Task/Issue URL: https://app.asana.com/0/1205008441501016/1209119876664187 ### Description * Add visibleAndOnByDefault subfeature, so we can perform an incremental rollout * Add canUpdateDatasets subfeature, so we can turn off dataset downloads if needed * Force update datasets when RC flag is turned on
Task/Issue URL: https://app.asana.com/0/414730916066338/1209489657638562 ### Description This PR fixes 2 bookmarks screen UI issues: - display of long bookmark folder titles in the toolbar - incorrect more menu button alignment for folders in the bookmark list ### Steps to test this PR _Title_ - [x] Make sure you have some existing bookmarks - [x] Go to the bookmarks screen - [x] Add a new bookmark folder with a long name, such as "This is a very long bookmark folder name" - [x] Tap on the bookmark - [x] Verify the toolbar title text is on a single line and wrapped _List_ - [x] Make sure you have some existing bookmarks - [x] Go to the bookmarks screen - [x] Add a new bookmark folder - [x] Verify the more menu button at the end of the folder item is aligned with the rest of the bookmarks ### UI changes _Title_ | Before | After | | ------ | ----- | || _List_ | Before | After | | ------ | ----- | ||
Task/Issue URL: https://app.asana.com/0/1202561462274611/1209546742794599 ### Description ⬆️ Updates the following dependencies: AGP to from 8.5.1 to 8.7.3 Gradle wrapper from 8.8 to 8.10.2 Tested building & ran unit tests both on Android Studio and IntelliJ IDEA, no issues found. ### Steps to test this PR Make sure all requirements are green.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209304069660515 ### Description * Add Malicious Site Protection algorithm pixels ### Steps to test this PR _Feature 1_ - [x] Load https://privacy-test-pages.site/security/badware/phishing-legit-iframe-loader.html - [x] Check m_malicious-site-protection_iframe-loaded with params: {category=phishing} is fired - [x] Check m_malicious-site-protection_error-page-shown is fired _Feature 2_ - [x] Set timeout to 10ms in override suspend fun matches(hashPrefix: String): List<Match> - [x] Load https://privacy-test-pages.site/security/badware/phishing-legit-iframe-loader.html - [x] Check no error page is shown and m_malicious-site-protection_client-timeout is fired _Feature 3_ - [x] Load https://privacy-test-pages.site/security/badware/ - [x] Click on "Phishing iFrame Loader" - [x] Check m_malicious-site-protection_iframe-loaded and m_malicious-site-protection_error-page-shown are fired only once ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/488551667048375/1209403916411874 ### Description ### Steps to test this PR Affected workflows complete: - CI: https://github.com/duckduckgo/Android/actions/runs/13625393810 - Nightly: https://github.com/duckduckgo/Android/actions/runs/13625429418 - Release test: https://github.com/duckduckgo/Android/actions/runs/13625705799 - Release report error: N/A
…5688) Task URL: https://app.asana.com/0/488551667048375/1209483504518112 ### Description We removed the splashscreen animation while investigating issues due to a user report of a black screen when launching. This reverts that removal and will be a feature branch for adding upcoming mitigations to reduce chances of this happening. Task/Issue URL: https://app.asana.com/0/1207908166761516/1209495201524764 ### Description Added a fallback mechanism to handle cases where the splash screen exit animation fails to trigger. The fallback automatically proceeds to the next screen after a 1.5-second delay if the normal exit animation doesn't occur. We now also only target Android 13 and above with the Splashscreen animation after seeing mention of issues on Android 12L. ### Steps to test this PR _Android 12L testing fallback_ - [ ] We can actually rely on the Android Studio launch bug to test this - [ ] Create an emulator with API 32 (get one with the play store) - [ ] Run the branch from the Android Studio - [ ] The app should *not* show the splashscreen (remember we're using the bug - [ ] Check that `m_splashscreen_failed_to_launch` pixel fired - [ ] After ~1.5 seconds the app should launch into onboarding/browser _Android 12L testing normal launch_ - [ ] Close the app from before - [ ] Locate the app on the home screen/app launcher - [ ] Launch the app - [ ] The static logo splashscreen should show - [ ] The app should launch into onboarding/browser _Test other OS versions_ Test that the splashscreen still works on other Android OS versions. A suggested range could be 26, 30, 33, 35 On 33+ - [x] Open the app - [x] Animated splashscreen should play - [x] The app should launch into onboarding/browser On <= 32 - [ ] Open the app - [x] Static splashscreen logo should be visible - [ ] The app should launch into onboarding/browser ### UI changes No visual changes to the splash screen appearance or animation.
Task/Issue URL: https://app.asana.com/0/1200156640058969/1209279712661813 ### Description Adds fallback logic when package Id couldn't be found when traversing the view hierarchy. ### Steps to test this PR smoke test feature works as usual _Feature 1_ - [ ] install Max android app - [ ] go to the login form - [ ] you should now get a suggestion "open passwords) indicating we've detected the login form ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/1200156640058969/1209226370597334 ### Description Signal autofill Ids not classified to be ignored ### Steps to test this PR (optional) just smoke test the feature ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/0/1209226370597335/f ### Description Expands list of browsers to improve suggestions there. Only show suggestions if site has been detected ### Steps to test this PR N/A ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/1200156640058969/1209552039022764 ### Description Adds support to remote exceptions if any ### Steps to test this PR _Feature 1_ - [ ] Update Privacy config endpoint with `https://www.jsonblob.com/api/1345893009585266688` - [ ] Install the app - [ ] Select DDG as Autofill Provider - [ ] Go to another browser, and visit fill.dev - [ ] You should not get suggestions. ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/608920331025315/1209488709393051 ### Description Changes how we compare usernames to make them case-insensitive. Autofill subfeature `ignoreCaseOnUsernameComparisons` guards the new behaviour. - new behaviour is enabled by default - disable the flag to revert to old behaviour #### Where this change applies - If multiple credentials saved which are identical apart from casing on username, these will be considered duplicates from the credential picker view (meaning they’ll be de-duped) - If you already have a credential saved and are trying to save a new one with same username, the comparison between usernames will be case insensitive. So if `user` is saved and `USER` comes from the JS, these will be treated as equivalent - The password management view will always show all saved credentials (no de-duping in this view) ### Steps to test this PR #### De-duping credential picker - [x] fresh `internal` install - [x] Visit `Autofill Dev Settings` (from `Settings -> Autofill Dev Settings`) - [x] Tap on `Add mixed case username duplicates` - [x] Visit https://autofill.me/form/login-simple, verify you are prompted to autofill with **only 1 option offered** - [x] Agree to autofill, and confirm it autofills successfully #### Across subdomains - [x] Visit password management screen, and choose one of the credentials to edit - [x] Change its URL to have a subdomain (e.g. `example.autofill.me`) but keep the username - [x] Add a new credential (`username=john`, `password=password`, `url=example.autofill.me`) and save - [x] Return to https://autofill.me/form/login-simple (and refresh) - [x] Verify you see 1 option `From This Website`, and 1 option `From example.autofill.me` (this verifies that it de-duped the username where case was different but credential was otherwise identical, and still included the credential for a subdomain with a different username) #### Prompted to update password (not save a new one) when only difference is casing on username - [x] Visit https://autofill.me/form/registration-username - [x] For username, enter `USERname` (match the case exactly) - [x] For password, enter something different from what’s stored (e.g., `new-password` or autogenerate it) - [x] Tap `Register` button. Verify you are prompted to `Update password` for the username - [ ] Agree. Now visit password management page and verify the password has been updated for all 3 entries (by design, it updates multiple matches) #### Reverting to old behaviour - [x] Tap on `Settings -> Feature Flag Inventory`, and disable `ignoreCaseOnUsernameComparisons` - [x] Verify the production behaviour happens. e.g., - you get offered all saved passwords to autofill, even the “duplicates” - if you register using a username containing case differences, you are prompted to save rather than update Co-authored-by: Craig Russell <[email protected]>
…g code to match expected schema (#5702) Task/Issue URL: https://app.asana.com/0/1208671518894266/1209523191422601
Task/Issue URL: https://app.asana.com/0/488551667048375/1209504297651004 ### Description - Added dependency tree creation for pir process - Made getCache and getDir run on any secondary process ### Steps to test this PR Make sure on a fresh install VPN doesn’t crash.
Task/Issue URL: https://app.asana.com/0/1142021229838617/1209560036159812 ### Description Fix privacy shield flickering by not updating the animation if unchanged ### Steps to test this PR _Feature 1_ - Smoke test privacy shield in both MSP and regular sites. The icon shouldn't flicker with the same status --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1209567544947320
Task/Issue URL: https://app.asana.com/0/488551667048375/1209571266884765 ### Description Don't call renderPrivacyIcon if another leadingIcon is being shown. Otherwise, lastSeenPrivacyShield might contain inaccurate data of a state that was never displayed, leading to inconsistent UI ### Steps to test this PR _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Task/Issue URL: https://app.asana.com/0/488551667048375/1209564665484120/f ----- - Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/488551667048375/1209572281087336 ### Description Added temporary pixel parameters to the splash screen failed to launch pixel to help diagnose splash screen issues. ### Steps to test this PR _Splash Screen Pixel Params_ - [x] Launch the app on Android 12L (32) using Android Studio and verify it opens normally. As we know there's a bug launching from Android Studio you should NOT see the splashscreen logo. - [x] Check logcat for `m_splashscreen_failed_to_launch` pixel and check it includes "launcherPackageName" and "api" parameters - [x] Verify the launcher package name matches your device's default launcher - [x] Verify the API level matches your device's Android version ### UI changes No UI changes
Task/Issue URL: https://app.asana.com/0/488551667048375/1209576197948280/f ----- - Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/488551667048375/1209576095129832/f ----- - Automated reference tests dependency update This PR updates the reference tests dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/0/1203766026095653/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1209560625119542/f ### Description Disable MSP in F-Droid builds ### Steps to test this PR _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1209568836821773
…ed in BE (#5608) Task/Issue URL: https://app.asana.com/0/488551667048375/1209345290223153/f ### Description This PR addresses an edge case, where where re-purchasing an expired subscription may be temporarily impossible. See task for details. ### Steps to test this PR QA-optional ### No UI changes
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209584430633449 ### Description Added `offerId` parameter with null default value to the `purchase` method call in `RealSubscriptionsManagerTest`. The PR where the test was added: [`d5315e0` (#5608)](d5315e0#r1983806357) ### Steps to test this PR _Purchase Method Testing_ - [x] Verify that existing purchase tests continue to pass ### UI changes No UI changes in this PR
Task/Issue URL: https://app.asana.com/0/488551667048375/1209603311550623/f ----- - Automated content scope scripts dependency update This PR updates the content scope scripts dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/1205617573940217/1209600288549962/f ### Description ### Steps to test this PR QA-optional ### No UI changes
- Automated reference tests dependency update This PR updates the reference tests dependency to the latest available version and copies the necessary files. If tests have failed, see https://app.asana.com/0/0/1203766026095653/f for further information on what to do next. - [ ] All tests must pass Co-authored-by: daxmobile <[email protected]>
Task/Issue URL: https://app.asana.com/0/1209610620847062/1209610620847062 Autoconsent Release: https://github.com/duckduckgo/autoconsent/releases/tag/v12.13.0 ## Description Updates Autoconsent to version [v12.13.0](https://github.com/duckduckgo/autoconsent/releases/tag/v12.13.0). ### Autoconsent v12.13.0 release notes See release notes [here](https://github.com/duckduckgo/autoconsent/blob/v12.13.0/CHANGELOG.md) ## Steps to test This release has been tested during Autoconsent development. You can check the release notes for more information. 1. Make sure that there's no unexpected failures in CI checks 2. (optional) smoke test some of the sites mentioned in the release notes 3. If there are problems, reach out to a CPM DRI Co-authored-by: muodov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )