Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): improve htmlReport UX #60

Merged
merged 3 commits into from
Jan 27, 2025
Merged

feat(html): improve htmlReport UX #60

merged 3 commits into from
Jan 27, 2025

Conversation

AugustinMauroy
Copy link
Contributor

  • Dark theme
  • Environnement info (so if html is share user know how/where it's was bench)
  • add link to the GH repo

RafaelGSS
RafaelGSS reviewed Jan 25, 2025
View reviewed changes
Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a video of the result? Please, test it in different resolutions if possible.

@RafaelGSS RafaelGSS changed the title feat(html): improve UX feat(html): improve htmlReport UX Jan 25, 2025
@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Jan 25, 2025 •
edited
Loading

Capture d’écran 2025-01-25 à 16 44 21 Capture d’écran 2025-01-25 à 22 20 28 Capture d’écran 2025-01-25 à 22 20 38

RafaelGSS
RafaelGSS reviewed Jan 26, 2025
View reviewed changes
Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, can we create a "gif export" from it?

@RafaelGSS
Copy link
Owner

Of course, that's out of this PR scope. Just thought on it as a follow up work.

@AugustinMauroy
Copy link
Contributor Author

I wonder, can we create a "gif export" from it?

HEHEH not funny I dunno how to create that using my Mac 😅

@RafaelGSS
Copy link
Owner

Can you amend the commit message to satisfy our tests?

@RafaelGSS
Copy link
Owner

also, it seems the benchmark name is overriding the box

@AugustinMauroy
Copy link
Contributor Author

also, it seems the benchmark name is overriding the box

It's fix on lasted commit
Capture d’écran 2025-01-27 à 08 39 38

@RafaelGSS RafaelGSS merged commit 79ce533 into RafaelGSS:main Jan 27, 2025
3 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 25, 2025
Merged
@AugustinMauroy AugustinMauroy deleted the feat(html)-dark-them branch January 27, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustinMauroy @RafaelGSS