tests pass

Ragazoor · Apr 6, 2024 · 1fde620 · 1fde620
1 parent 6ff2fb2
commit 1fde620
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/result/src/main/scala/io/github/ragazoor/IO.scala b/result/src/main/scala/io/github/ragazoor/IO.scala
@@ -31,7 +31,7 @@ sealed trait IO[+E <: Throwable, +A] extends Awaitable[A] {
   def mapError[E2 <: Throwable](f: E => E2)(implicit ec: ExecutionContext): IO[E2, A] = {
     var isFutureFatal     = isFatal
     val transformedFuture = self.toFuture.transform {
-      case Failure(e) if NonFatal(e) || !isFatal  => Failure(f(e.asInstanceOf[E]))
+      case Failure(e) if NonFatal(e) && !isFatal  => Failure(f(e.asInstanceOf[E]))
       case Failure(e) if !NonFatal(e) || isFatal =>
         isFutureFatal = true
         Failure(e)

diff --git a/result/src/test/scala/io/github/ragazoor/IOSpec.scala b/result/src/test/scala/io/github/ragazoor/IOSpec.scala
@@ -190,20 +190,21 @@ class IOSpec extends FunSuite {
       .map(result => assert(result == 2))
   }
 
-
   test("IO mapError cannot catch fatal errors") {
     val result = for {
       _ <- IO.fatal(new RuntimeException("Test message"))
     } yield assert(false)
 
     result
-    .mapError(MyError.apply)
-    .catchSome { case _: MyError =>
-      IO.successful(assert(false))
-    }
-    .toFuture
-    .recover {
-      case _: RuntimeException => assert(true)
-    }
+      .mapError(MyError.apply)
+      .catchSome { case _: MyError =>
+        IO.successful(assert(false))
+      }
+      .toFuture
+      .recover {
+        case _: RuntimeException => assert(true)
+        case e                   => assert(e.getMessage == "Test message")
+      }
+
   }
 }