-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Retry failed jobs #1626
base: main
Are you sure you want to change the base?
ci: Retry failed jobs #1626
Conversation
The e2e job is not stale enough. Save developers time by retrying failed e2e tests 3 times before failing the job. Signed-off-by: Nir Soffer <[email protected]>
Our unit tests are not stable enough. Save developer time by retrying failed runs 3 times before failing the build. Signed-off-by: Nir Soffer <[email protected]>
I'd rather not auto retry so that we can catch and post analysis for failures and enable improving the tests/flakes. This way PRs may get a 1 in 3 (or n) chance of a passing and failures (flake or otherwise) is not analyzed and ignored. |
I agree with Shyam. Let the retries be manual. |
Manual retries are fine, but they are not available for people without commit right. We need a way to trigger a rebuild without write permission. |
The e2e and unit tests are not stable enough. Save developers time by retrying failed jobs automatically before failing the build.
Example run - unit tests failed in first attempt, succeeded in the second attempt:
https://github.com/RamenDR/ramen/actions/runs/11580608689/job/32239498144