Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add volsync tests with no SC Labels #1740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add volsync tests with no SC Labels #1740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad2155a
refactor createSC() and createVSC()
rakeshgm Dec 29, 2024
f331162
volsync: added test without SIDs and Peerclasses
rakeshgm Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
244 changes: 180 additions & 64 deletions internal/controller/vrg_volsync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,29 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
var testCtx context.Context
var cancel context.CancelFunc

vrgAsyncPeerClasses := func() []ramendrv1alpha1.PeerClass {
return []ramendrv1alpha1.PeerClass{peerClass(testStorageClassName, sIDs)}
}

testCapacity := func(capacity string) corev1.ResourceList {
return corev1.ResourceList{
corev1.ResourceStorage: resource.MustParse(capacity),
}
}

protectedPVC := func(storageClassName, testPVCName string, testCapacity corev1.ResourceList,
testAccessModes []corev1.PersistentVolumeAccessMode,
) ramendrv1alpha1.ProtectedPVC {
return ramendrv1alpha1.ProtectedPVC{
Name: testPVCName,
Namespace: testNamespace.GetName(),
ProtectedByVolSync: true,
StorageClassName: &storageClassName,
AccessModes: testAccessModes,
Resources: corev1.VolumeResourceRequirements{Requests: testCapacity},
}
}

BeforeEach(func() {
testCtx, cancel = context.WithCancel(context.TODO())

Expand All @@ -82,9 +105,6 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
testMatchLabels := map[string]string{
"ramentest": "backmeup",
}
vrgAsyncPeerClasses := func() []ramendrv1alpha1.PeerClass {
return []ramendrv1alpha1.PeerClass{peerClass(testStorageClassName, sIDs)}
}

var testVsrg *ramendrv1alpha1.VolumeReplicationGroup

Expand Down Expand Up @@ -122,8 +142,8 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
ContainElement("volumereplicationgroups.ramendr.openshift.io/vrg-protection"))

createSecret(testVsrg.GetName(), testNamespace.Name)
createSC()
createVSC()
createSC(testStorageClassName, scLabels())
createVSC(testVolumeSnapshotClass, vscLabels())
})

Context("When no matching PVCs are bound", func() {
Expand All @@ -149,7 +169,7 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {

// Create some PVCs that are bound
for i := 0; i < 3; i++ {
newPvc := createPVCBoundToRunningPod(testCtx, testNamespace.GetName(),
newPvc := createPVCBoundToRunningPod(testCtx, testNamespace.GetName(), testStorageClassName,
testMatchLabels, pvcAnnotations)
boundPvcs = append(boundPvcs, *newPvc)
}
Expand Down Expand Up @@ -211,29 +231,9 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
return len(allRSs.Items)
}, testMaxWait, testInterval).Should(Equal(len(testVsrg.Status.ProtectedPVCs)))

rs0 := &volsyncv1alpha1.ReplicationSource{}
Expect(k8sClient.Get(testCtx, types.NamespacedName{
Name: boundPvcs[0].GetName(), Namespace: testNamespace.GetName(),
}, rs0)).To(Succeed())
Expect(rs0.Spec.SourcePVC).To(Equal(boundPvcs[0].GetName()))
Expect(rs0.Spec.Trigger).NotTo(BeNil())
Expect(*rs0.Spec.Trigger.Schedule).To(Equal("0 */1 * * *")) // scheduling interval was set to 1h

rs1 := &volsyncv1alpha1.ReplicationSource{}
Expect(k8sClient.Get(testCtx, types.NamespacedName{
Name: boundPvcs[1].GetName(), Namespace: testNamespace.GetName(),
}, rs1)).To(Succeed())
Expect(rs1.Spec.SourcePVC).To(Equal(boundPvcs[1].GetName()))
Expect(rs1.Spec.Trigger).NotTo(BeNil())
Expect(*rs1.Spec.Trigger.Schedule).To(Equal("0 */1 * * *")) // scheduling interval was set to 1h

rs2 := &volsyncv1alpha1.ReplicationSource{}
Expect(k8sClient.Get(testCtx, types.NamespacedName{
Name: boundPvcs[2].GetName(), Namespace: testNamespace.GetName(),
}, rs2)).To(Succeed())
Expect(rs2.Spec.SourcePVC).To(Equal(boundPvcs[2].GetName()))
Expect(rs2.Spec.Trigger).NotTo(BeNil())
Expect(*rs2.Spec.Trigger.Schedule).To(Equal("0 */1 * * *")) // scheduling interval was set to 1h
for _, boundPVC := range boundPvcs {
verifyReplicationSourceCreated(testCtx, &volsyncv1alpha1.ReplicationSource{}, boundPVC, testNamespace)
}
})
})
})
Expand Down Expand Up @@ -262,6 +262,7 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
ReplicationState: ramendrv1alpha1.Secondary,
Async: &ramendrv1alpha1.VRGAsyncSpec{
SchedulingInterval: "1h",
PeerClasses: vrgAsyncPeerClasses(),
},
PVCSelector: metav1.LabelSelector{
MatchLabels: testMatchLabels,
Expand All @@ -283,48 +284,29 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
ContainElement("volumereplicationgroups.ramendr.openshift.io/vrg-protection"))

createSecret(testVrg.GetName(), testNamespace.Name)
createSC()
createVSC()
createSC(testStorageClassName, scLabels())
createVSC(testVolumeSnapshotClass, vscLabels())
})

Context("When RDSpec entries are added to vrg spec", func() {
storageClassName := testStorageClassName

testCapacity0 := corev1.ResourceList{
corev1.ResourceStorage: resource.MustParse("1Gi"),
}
testCapacity1 := corev1.ResourceList{
corev1.ResourceStorage: resource.MustParse("20Gi"),
}

rd0 := &volsyncv1alpha1.ReplicationDestination{}
rd1 := &volsyncv1alpha1.ReplicationDestination{}

JustBeforeEach(func() {
// Update the vrg spec with some RDSpec entries
Expect(k8sClient.Get(testCtx, client.ObjectKeyFromObject(testVrg), testVrg)).To(Succeed())

testVrg.Spec.VolSync.RDSpec = []ramendrv1alpha1.VolSyncReplicationDestinationSpec{
{
ProtectedPVC: ramendrv1alpha1.ProtectedPVC{
Name: "testingpvc-a",
Namespace: testNamespace.GetName(),
ProtectedByVolSync: true,
StorageClassName: &storageClassName,
AccessModes: testAccessModes,

Resources: corev1.VolumeResourceRequirements{Requests: testCapacity0},
},
ProtectedPVC: protectedPVC(storageClassName,
"testingpvc-a", testCapacity("1Gi"), testAccessModes),
},

{
ProtectedPVC: ramendrv1alpha1.ProtectedPVC{
Name: "testingpvc-b",
Namespace: testNamespace.GetName(),
ProtectedByVolSync: true,
StorageClassName: &storageClassName,
AccessModes: testAccessModes,

Resources: corev1.VolumeResourceRequirements{Requests: testCapacity1},
},
ProtectedPVC: protectedPVC(storageClassName,
"testingpvc-b", testCapacity("20Gi"), testAccessModes),
},
}

Expand Down Expand Up @@ -395,10 +377,127 @@ var _ = Describe("VolumeReplicationGroupVolSyncController", func() {
})
})
})

Describe("Setup without SIDs and PeerClasses", func() {
testMatchLabels := map[string]string{
"ramentest": "backmeup",
}

var testVsrg *ramendrv1alpha1.VolumeReplicationGroup

PVCCount := 3

Context("When VRG created", func() {
JustBeforeEach(func() {
testVsrg = &ramendrv1alpha1.VolumeReplicationGroup{
ObjectMeta: metav1.ObjectMeta{
GenerateName: "test-vrg-east-",
Namespace: testNamespace.GetName(),
},
Spec: ramendrv1alpha1.VolumeReplicationGroupSpec{
ReplicationState: ramendrv1alpha1.Primary,
Async: &ramendrv1alpha1.VRGAsyncSpec{
SchedulingInterval: "1h",
},
PVCSelector: metav1.LabelSelector{
MatchLabels: testMatchLabels,
},
S3Profiles: []string{s3Profiles[0].S3ProfileName},
VolSync: ramendrv1alpha1.VolSyncSpec{},
},
}

Expect(k8sClient.Create(testCtx, testVsrg)).To(Succeed())

Eventually(func() []string {
err := k8sClient.Get(testCtx, client.ObjectKeyFromObject(testVsrg), testVsrg)
if err != nil {
return []string{}
}

return testVsrg.GetFinalizers()
}, testMaxWait, testInterval).Should(
ContainElement("volumereplicationgroups.ramendr.openshift.io/vrg-protection"))

createSecret(testVsrg.GetName(), testNamespace.Name)
createSC("sc1", map[string]string{})
createVSC("vsc1", map[string]string{})
})

Context("When matching PVCs are bound", func() {
var boundPvcs []corev1.PersistentVolumeClaim

pvcAnnotations := map[string]string{
"apps.open-cluster-management.io/hosting-subscription": "sub-name",
"apps.open-cluster-management.io/reconcile-option": "merge",
volsync.ACMAppSubDoNotDeleteAnnotation: volsync.ACMAppSubDoNotDeleteAnnotationVal,
"pv.kubernetes.io/bind-completed": "yes",
"volume.kubernetes.io/storage-provisioner": "provisioner",
}

JustBeforeEach(func() {
// Reset for each test
boundPvcs = []corev1.PersistentVolumeClaim{}

// Create some PVCs that are bound
for i := 0; i < PVCCount; i++ {
newPvc := createPVCBoundToRunningPod(testCtx, testNamespace.GetName(), "sc1",
testMatchLabels, pvcAnnotations)
boundPvcs = append(boundPvcs, *newPvc)
}

Eventually(func() int {
err := k8sClient.Get(testCtx, client.ObjectKeyFromObject(testVsrg), testVsrg)
if err != nil {
return 0
}

return len(testVsrg.Status.ProtectedPVCs)
}, testMaxWait, testInterval).Should(Equal(len(boundPvcs)))
})

It("Should find the bound PVCs and report in Status", func() {
// Check the volsync pvcs
foundBoundPVC0 := false
foundBoundPVC1 := false
foundBoundPVC2 := false
for _, vsPvc := range testVsrg.Status.ProtectedPVCs {
switch vsPvc.Name {
case boundPvcs[0].GetName():
foundBoundPVC0 = true
case boundPvcs[1].GetName():
foundBoundPVC1 = true
case boundPvcs[2].GetName():
foundBoundPVC2 = true
}
}
Expect(foundBoundPVC0).To(BeTrue())
Expect(foundBoundPVC1).To(BeTrue())
Expect(foundBoundPVC2).To(BeTrue())
})

Context("When RSSpec entries are added to vrg spec", func() {
It("Should create ReplicationSources for each", func() {
allRSs := &volsyncv1alpha1.ReplicationSourceList{}
Eventually(func() int {
Expect(k8sClient.List(testCtx, allRSs,
client.InNamespace(testNamespace.GetName()))).To(Succeed())

return len(allRSs.Items)
}, testMaxWait, testInterval).Should(Equal(len(testVsrg.Status.ProtectedPVCs)))

for _, boundPVC := range boundPvcs {
verifyReplicationSourceCreated(testCtx, &volsyncv1alpha1.ReplicationSource{}, boundPVC, testNamespace)
}
})
})
})
})
})
})

//nolint:funlen
func createPVCBoundToRunningPod(ctx context.Context, namespace string,
func createPVCBoundToRunningPod(ctx context.Context, namespace, scName string,
labels map[string]string, annotations map[string]string,
) *corev1.PersistentVolumeClaim {
capacity := corev1.ResourceList{
Expand All @@ -408,7 +507,7 @@ func createPVCBoundToRunningPod(ctx context.Context, namespace string,
corev1.ReadWriteOnce,
}

storageClassName := testStorageClassName
storageClassName := scName

pvc := &corev1.PersistentVolumeClaim{
TypeMeta: metav1.TypeMeta{},
Expand Down Expand Up @@ -486,15 +585,18 @@ func createSecret(vrgName, namespace string) {
Expect(secret.GetName()).NotTo(BeEmpty())
}

func createSC() {
func createSC(storageClassName string, scLabels map[string]string) {
sc := &storagev1.StorageClass{
ObjectMeta: metav1.ObjectMeta{
Name: testStorageClassName,
Labels: scLabels(),
Name: storageClassName,
},
Provisioner: "manual.storage.com",
}

if len(scLabels) != 0 {
sc.ObjectMeta.Labels = scLabels
}

err := k8sClient.Create(context.TODO(), sc)
if err != nil {
if k8serrors.IsAlreadyExists(err) {
Expand All @@ -506,16 +608,19 @@ func createSC() {
"failed to create/get StorageClass %s", sc.Name)
}

func createVSC() {
func createVSC(vscName string, vscLabels map[string]string) {
vsc := &snapv1.VolumeSnapshotClass{
ObjectMeta: metav1.ObjectMeta{
Name: testVolumeSnapshotClass,
Labels: vscLabels(),
Name: vscName,
},
Driver: "manual.storage.com",
DeletionPolicy: snapv1.VolumeSnapshotContentDelete,
}

if len(vscLabels) != 0 {
vsc.ObjectMeta.Labels = vscLabels
}

err := k8sClient.Create(context.TODO(), vsc)
if err != nil {
if k8serrors.IsAlreadyExists(err) {
Expand All @@ -526,3 +631,14 @@ func createVSC() {
Expect(err).NotTo(HaveOccurred(),
"failed to create/get StorageClass %s", vsc.Name)
}

func verifyReplicationSourceCreated(testCtx context.Context, rs *volsyncv1alpha1.ReplicationSource,
boundPVC corev1.PersistentVolumeClaim, ns *corev1.Namespace,
) {
Expect(k8sClient.Get(testCtx, types.NamespacedName{
Name: boundPVC.GetName(), Namespace: ns.GetName(),
}, rs)).To(Succeed())
Expect(rs.Spec.SourcePVC).To(Equal(boundPVC.GetName()))
Expect(rs.Spec.Trigger).NotTo(BeNil())
Expect(*rs.Spec.Trigger.Schedule).To(Equal("0 */1 * * *")) // scheduling interval was set to 1h
}