Fix CG PVC Selection Issue Due to storageId Mismatch & Improve Grouping Algorithm
#1809
+128
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we started using storageId as part of the label to determine whether a PVC belongs to a consistency group. While the initial deployment and synchronization from primary to secondary clusters work correctly, failover or relocation results in a different storageId on the new primary. This mismatch causes issues when setting up the source and destination again. This fix ensures that PVC selection accounts for storageId differences to maintain correct CG membership during failover and relocation. Signed-off-by: Benamar Mekhissi <[email protected]>
asn1809
approved these changes
Feb 6, 2025
ShyamsundarR
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we started using
storageIdas part of the label to determine whether a PVC belongs to a consistency group. While the initial deployment and synchronization from the primary to the secondary cluster work correctly, failover or relocation results in a differentstorageIdon the new primary.This mismatch caused issues when setting up the source and destination again, leading to leaving
ReplicationDestinationbehind causing the sync to occur locally.Additionally, I refactored the algorithm responsible for building the groups while addressing this issue. The previous implementation was too complex and inefficient. The new approach simplifies the grouping logic while improving performance and making it easier to maintain.
Moreover, the
ReplicationGroupDestinationandReplicationGroupSourceresource names were too long and tedious to type. To improve usability, I introduced shorter aliases when usingoc get. Now, you can simply run:oc get rgdinstead ofoc get replicationgroupdestinationoc get rgsinstead ofoc get replicationgroupsourceFixes: DFBUGS-1520
Note: For 4.19, we’ll be switching to
ReplicationIDinstead ofstorageId. This change won’t affect the refactoring done in this PR.