Add ability to set read at on feedback #610
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| response | ||
| rescue StandardError => e | ||
| Sentry.capture_exception(e) | ||
| response[:error] = response[:feedback]&.errors |
| response | ||
| rescue StandardError => e | ||
| Sentry.capture_exception(e) | ||
| response[:error] = response[:feedback]&.errors |
There was a problem hiding this comment.
This follows existing patterns, so I think it's fine
| it 'returns the updated feedback' do | ||
| response = described_class.call(feedback: feedback) | ||
| expect(response[:feedback]).to eq(feedback) | ||
| end |
There was a problem hiding this comment.
I'm a bit confused what this is testing to be honest. Might be simpler to test it is an instance of Feedback and then check the read at was set below like you're already doing
|
|
||
| context 'when set_read fails' do | ||
| before do | ||
| allow(feedback).to receive(:save!).and_raise(StandardError, 'Transition failed') |
There was a problem hiding this comment.
Very nitpicky sorry, but there might be a better example of an error message, just because Transition failed is quite specific to the state machine stuff
| it 'returns the original feedback' do | ||
| response = described_class.call(feedback: feedback) | ||
| expect(response[:feedback]).to eq(feedback) | ||
| end |
There was a problem hiding this comment.
this is the same test as the one you have above, where response[:feedback] should have changed, so I'm confused
| it 'includes an error object in the response' do | ||
| response = described_class.call(feedback: feedback) | ||
| expect(response[:error]).to be_a(ActiveModel::Errors) |
There was a problem hiding this comment.
might be good to test it returns the error you set above
| def set_read | ||
| feedback = Feedback.find(params[:id]) | ||
| result = Feedback::SetRead.call(feedback: feedback) | ||
|
|
||
| if result.success? | ||
| @feedback = result[:feedback] | ||
| render :show, formats: [:json], status: :ok | ||
| else | ||
| render json: { error: result[:error] }, status: :unprocessable_entity | ||
| end | ||
| end |
There was a problem hiding this comment.
do we want to 404 it if the feedback id is invalid?
Status
What's changed?