Skip to content

3.x: Add step to JDK 11 build to verify generated module-info #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 6, 2021

When building the module-info via the beryx plugin on Java 8, there is no verification for the contents possible. Therefore, the plugin documentation suggest building with a newer JDK and specifying a 9+ target.

Related #7241

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #7334 (74143a9) into 3.x (ce45fc2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7334      +/-   ##
============================================
- Coverage     99.55%   99.53%   -0.03%     
+ Complexity     6781     6779       -2     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47271    47260      -11     
- Misses           94      100       +6     
- Partials        117      122       +5     
Impacted Files Coverage Δ
...vex/rxjava3/internal/operators/maybe/MaybeAmb.java 96.96% <0.00%> (-3.04%) ⬇️
...va/io/reactivex/rxjava3/subjects/MaybeSubject.java 97.75% <0.00%> (-2.25%) ⬇️
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0.00%> (-1.99%) ⬇️
...nternal/operators/observable/ObservableCreate.java 96.58% <0.00%> (-1.71%) ⬇️
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 94.36% <0.00%> (-0.71%) ⬇️
.../operators/observable/ObservableCombineLatest.java 99.38% <0.00%> (-0.62%) ⬇️
...operators/flowable/FlowableConcatMapScheduler.java 99.20% <0.00%> (-0.40%) ⬇️
...ternal/operators/observable/ObservableFlatMap.java 97.87% <0.00%> (-0.36%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce45fc2...74143a9. Read the comment docs.

@akarnokd akarnokd merged commit 476aa5c into ReactiveX:3.x Sep 6, 2021
@akarnokd akarnokd deleted the ModuleVerify3x branch September 6, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant