Removed unused code

RealA10N · Aug 2, 2024 · ffdef29 · ffdef29
1 parent f1e1f8e
commit ffdef29
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 14 deletions.
diff --git a/parse/argument.go b/parse/argument.go
@@ -13,7 +13,7 @@ type ArgumentNode struct {
 
 type ArgumentParser struct{}
 
-func (p ArgumentParser) Parse(v *TokenView) (node ArgumentNode, err ParsingError) {
+func (ArgumentParser) Parse(v *TokenView) (node ArgumentNode, err ParsingError) {
 	typ, err := ConsumeToken(v, lex.TypToken)
 	if err != nil {
 		return

diff --git a/parse/argument_test.go b/parse/argument_test.go
@@ -11,7 +11,6 @@ import (
 )
 
 func TestArgumentParserSimpleCase(t *testing.T) {
-	p := parse.ArgumentParser{}
 	v, ctx := source.NewSourceView("$i32 %0 .entry").Detach()
 
 	typView := v.Subview(0, 4)
@@ -23,7 +22,7 @@ func TestArgumentParserSimpleCase(t *testing.T) {
 	tkns := view.NewView[lex.Token, uint32]([]lex.Token{typTkn, regTkn, lblTkn})
 	expectedSubview := tkns.Subview(2, 3)
 
-	node, err := p.Parse(&tkns)
+	node, err := parse.ArgumentParser{}.Parse(&tkns)
 	assert.Nil(t, err)
 	assert.Equal(t, expectedSubview, tkns)
 
@@ -36,24 +35,22 @@ func TestArgumentParserSimpleCase(t *testing.T) {
 }
 
 func TestArgumentTypEofError(t *testing.T) {
-	p := parse.ArgumentParser{}
 	_, ctx := source.NewSourceView("").Detach()
 	tkns := []lex.Token{}
 	view := view.NewView[lex.Token, uint32](tkns)
 
-	_, err := p.Parse(&view)
+	_, err := parse.ArgumentParser{}.Parse(&view)
 	assert.NotNil(t, err)
 	assert.EqualValues(t, 0, view.Len())
 	assert.EqualValues(t, "expected <Type> token, but file ended", err.Error(ctx))
 }
 
 func TestArgumentRegEofError(t *testing.T) {
-	p := parse.ArgumentParser{}
 	v, ctx := source.NewSourceView("$i32").Detach()
 	tkn := lex.Token{Type: lex.TypToken, View: v}
 	view := view.NewView[lex.Token, uint32]([]lex.Token{tkn})
 
-	_, err := p.Parse(&view)
+	_, err := parse.ArgumentParser{}.Parse(&view)
 	assert.NotNil(t, err)
 	assert.EqualValues(t, 0, view.Len())
 	assert.EqualValues(t, "expected <Register> token, but file ended", err.Error(ctx))

diff --git a/parse/type.go b/parse/type.go
@@ -11,7 +11,7 @@ type TypeNode struct {
 
 type TypeParser struct{}
 
-func (p TypeParser) Parse(v *TokenView) (node TypeNode, err ParsingError) {
+func (TypeParser) Parse(v *TokenView) (node TypeNode, err ParsingError) {
 	tkn, err := ConsumeToken(v, lex.TypToken)
 	if err != nil {
 		return

diff --git a/parse/type_test.go b/parse/type_test.go
@@ -11,13 +11,12 @@ import (
 )
 
 func TestTypeParserSimpleCase(t *testing.T) {
-	p := parse.TypeParser{}
 	typView, ctx := source.NewSourceView("$i32").Detach()
 	typTkn := lex.Token{Type: lex.TypToken, View: typView}
 	tkns := view.NewView[lex.Token, uint32]([]lex.Token{typTkn})
 	expectedSubview := tkns.Subview(1, 1)
 
-	node, err := p.Parse(&tkns)
+	node, err := parse.TypeParser{}.Parse(&tkns)
 	assert.Nil(t, err)
 	assert.Equal(t, expectedSubview, tkns)
 
@@ -27,24 +26,22 @@ func TestTypeParserSimpleCase(t *testing.T) {
 }
 
 func TestTypeParserEofError(t *testing.T) {
-	p := parse.TypeParser{}
 	_, ctx := source.NewSourceView("").Detach()
 	tkns := []lex.Token{}
 	view := view.NewView[lex.Token, uint32](tkns)
 
-	_, err := p.Parse(&view)
+	_, err := parse.TypeParser{}.Parse(&view)
 	assert.NotNil(t, err)
 	assert.EqualValues(t, 0, view.Len())
 	assert.EqualValues(t, "expected <Type> token, but file ended", err.Error(ctx))
 }
 
 func TestTypeParserUnexpectedTokenError(t *testing.T) {
-	p := parse.TypeParser{}
 	regView, ctx := source.NewSourceView("%0").Detach()
 	regTkn := lex.Token{Type: lex.RegToken, View: regView}
 	tkns := view.NewView[lex.Token, uint32]([]lex.Token{regTkn})
 
-	_, err := p.Parse(&tkns)
+	_, err := parse.TypeParser{}.Parse(&tkns)
 	assert.NotNil(t, err)
 	assert.EqualValues(t, "expected <Type> token, but got <Register \"%0\">", err.Error(ctx))
 }