Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require explicit register type declaration #35

Conversation

RealA10N
Copy link
Owner

@RealA10N RealA10N commented Feb 7, 2025

No description provided.

Removed internal partial register information. Now each register must be declared at least once with an explicit type
@RealA10N RealA10N self-assigned this Feb 7, 2025
@RealA10N RealA10N linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (7a145c5) to head (3d795f7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gen/target_info.go 20.00% 8 Missing ⚠️
gen/target_generator.go 86.66% 4 Missing and 2 partials ⚠️
gen/label_argument.go 40.00% 3 Missing ⚠️
gen/immediate_info.go 0.00% 2 Missing ⚠️
gen/register_argument.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   77.61%   78.03%   +0.41%     
==========================================
  Files          67       68       +1     
  Lines        2484     2454      -30     
==========================================
- Hits         1928     1915      -13     
+ Misses        484      473      -11     
+ Partials       72       66       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RealA10N RealA10N marked this pull request as ready for review February 8, 2025 10:46
@RealA10N RealA10N merged commit f644df5 into main Feb 8, 2025
5 checks passed
@RealA10N RealA10N deleted the 32-false-positive-undefined-register-when-basic-blocks-are-unsorted branch February 8, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive: Undefined register when basic blocks are unsorted
1 participant