Skip to content

Conversation

@RealA10N
Copy link
Owner

@RealA10N RealA10N commented May 3, 2025

Closes #47

@RealA10N RealA10N added the core A core feature or change label May 3, 2025
@RealA10N RealA10N added this to the v0.1.0 milestone May 3, 2025
@RealA10N RealA10N requested a review from Copilot May 3, 2025 12:59
@RealA10N RealA10N self-assigned this May 3, 2025
@RealA10N RealA10N linked an issue May 3, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 177 lines in your changes missing coverage. Please review.

Project coverage is 42.11%. Comparing base (da3139b) to head (17d4640).

Files with missing lines Patch % Lines
transform/target.go 0.00% 87 Missing ⚠️
usm.go 0.00% 59 Missing ⚠️
transform/transformation.go 0.00% 19 Missing ⚠️
transform/target_data.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   42.32%   42.11%   -0.21%     
==========================================
  Files         114      117       +3     
  Lines        4281     4302      +21     
==========================================
  Hits         1812     1812              
- Misses       2383     2404      +21     
  Partials       86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the Unified Transformations API to streamline target handling and transformations while also refactoring package naming within the usm64 managers and extending command behavior in the usm tool.

  • Updates package names from "managers" to "usm64managers" across multiple files.
  • Refactors command functions in usm.go, adds a new targets variable for transformation chaining, and replaces several legacy commands.
  • Adds new transformation and target support with the creation of files under the transform folder.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
usm64/managers/types.go Package name updated to reflect the new module namespace.
usm64/managers/registers.go Package name updated accordingly.
usm64/managers/instructions.go Package name updated accordingly.
usm64/managers/context.go Package name updated accordingly.
usm.go Refactored command handling by introducing transformation targets and altering error output.
transform/transformation.go New transformation API definitions and helper functions.
transform/target_data.go New target data structure for managing code/artifact representations.
transform/target.go Implements target collection and transformation chain traversal and resolution.
Comments suppressed due to low confidence (1)

usm.go:132

  • The variable 'file' is undefined in the aarch64Command function. Consider opening the input file (as done in the ssaCommand) or using cmd.InOrStdin() to obtain the source.
view, err := core.ReadSource(file)

@RealA10N RealA10N merged commit 3eb7da9 into main May 3, 2025
3 of 5 checks passed
@RealA10N RealA10N deleted the 47-unified-transformations-api branch May 3, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core A core feature or change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified Transformations API

2 participants