remove "SharedVolumeService" design and "Uploading" status #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
- Added a new GitHub Action for publishing Docker images on dev branch pushes
- This action, named "docker_publish_dev", triggers on 'push' event specifically for 'dev' branch only
- Also included provision for manual workflow triggering with the use of 'workflow_dispatch'
- The job sequence includes checking out the code, setting Docker meta for Apache CouchDB and Azure CosmosDB, logging in to DockerHub and GitHub Container Registry, and building and pushing respective Docker images
- Moved the Docker images to ${{ secrets.DOCKERHUB_ORGANIZATION_NAME }}/${{ github.event.repository.name }} and ghcr.io/${{ github.repository }}
- Utilized Docker actions for login and metadata generation, and for building and pushing images.
Signed-off-by: 陳鈞 <[email protected]>
… LivestreamRecorderService - Change the `sync_ref` to target the `dev` branch instead of `master` in the `update-submodule` github action. Signed-off-by: 陳鈞 <[email protected]>
k8s.Autorest.HttpOperationException: Operation returned an invalid status code 'UnprocessableEntity', response body {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Job.batch \"ytdlpyvfcalhoalx0\" is invalid: spec.template.spec.containers[0].name: Invalid value: \"ytdlpyvfcalhoalx0_uploader\": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')","reason":"Invalid","details":{"name":"ytdlpyvfcalhoalx0","group":"batch","kind":"Job","causes":[{"reason":"FieldValueInvalid","message":"Invalid value: \"ytdlpyvfcalhoalx0_uploader\": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')","field":"spec.template.spec.containers[0].name"}]},"code":422}
Signed-off-by: 陳鈞 <[email protected]>
- Changed the argument path in `KubernetesServiceBase` to be filename only instead of a combination of mount path and filename - Fixed hardcoded 'MountPath' to be "/sharedvolume" in `KubernetesServiceBase` instead of dynamic mount path Signed-off-by: 陳鈞 <[email protected]>
- Added a new `cookies` volume to the Kubernetes service base configuration, sourced from a named secret. - Made the `cookies` volume optional with a default mode set to 660. - Created a mounting path for the `cookies` volume in the init containers configuration, keeping the property as not read-only. Signed-off-by: 陳鈞 <[email protected]>
|
Here's the code health analysis summary for commits Analysis Summary
|
Signed-off-by: 陳鈞 <[email protected]>
- Modify the handling of channel and video Ids for YouTube, Twitch, Twitcasting, and FC2 to better handle prefix changes for these platforms in `NameHelper.cs` - Correct the URL formation process in `YtdlpService.cs` to remove the unnecessary Id handling, thus directly appending `url` to the YouTube base URL Signed-off-by: 陳鈞 <[email protected]>
- Mark `UpdateVideosDataAsync` function in `Fc2Service` for future refactoring due to complexity - Mark `UpdateVideoDataAsync` function in `YoutubeService` for future refactoring due to complexity Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
Properties should not return arrays as they are not write protected CS-W1096 Signed-off-by: 陳鈞 <[email protected]>
…hDB.NET and EF Core Cosmos - Update `CouchDB.NET` package from version `3.6.0` to `3.6.1` - Update `Microsoft.EntityFrameworkCore.Cosmos` package from version `6.0.29` to `6.0.30` Signed-off-by: 陳鈞 <[email protected]>
- Bumped up the versions of several dependencies, such as `Azure.Identity`, `Azure.ResourceManager`, `Azure.ResourceManager.ContainerInstance`, `Azure.ResourceManager.Resources`, `Azure.Storage.Blobs`, `CouchDB.NET.DependencyInjection`, `Discord.Net.Webhook`, `KubernetesClient`, `Serilog.Sinks.Seq`, `Microsoft.EntityFrameworkCore.Cosmos`, and `Microsoft.EntityFrameworkCore.Design`. Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
… must be lowercase Error: buildx failed with: ERROR: failed to solve: failed to configure registry cache exporter: invalid reference format: repository name (Recorder-moe/LivestreamRecorderService) must be lowercase Signed-off-by: 陳鈞 <[email protected]>
Signed-off-by: 陳鈞 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedVolumeService design always causes problems in K8s, and increasing unnecessary expenses on Azure.