-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migrating personalization patterns to their own section #2173
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: -2 B (0%) Total Size: 207 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to link these to the pattern demo pages on their corresponding elements?
We'll tackle this in a full content overhaul. I just wanted to migrate the content to its new section, so Dustin, Sarah and others could begin updating. Ready for one last look if you got time @bennypowers and @marionnegp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Will the "Announcement" docs from feat(announcement): add
<rh-announcement>
v2 #2153 be moved here? (Sorry if I missed discussion around this.) -
Based on the updated personalization page's mockup, I'd remove every pattern except for "Announcement." Thoughts on this, @coreyvickery?
-
I know we're just getting this set up for edits, but I'm going to take a quick pass today or tomorrow on the "All personalization patterns" page to fix some images and other small things I noticed.
|
…te content on All personalization patterns page
@coreyvickery @markcaron, I updated the "All personalization patterns" page based on this mockup, so we'd (hopefully) have to make fewer edits later. Questions:
|
@marionnegp I'm ok with the change to cards if you think it's the right experience to link to the Element docs from the patterns list. Otherwise, we can find a spot in the pattern docs for a cross link (or both?). |
@markcaron, adding a cross link the pattern docs is a good call! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with merging this. I can open a new issue to add any Google doc links and to create a link from the announcement's personalization page to the announcement's element page once staging/cubone
is merged.
#2197 has the additional personalization and announcement page edits |
What I did
Testing Instructions
Notes to Reviewers