Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at second attempt to get Trusted Content configured. #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

First attempt at second attempt to get Trusted Content configured. #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions static/beta/stage/modules/fed-modules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,5 +980,22 @@
]
}
]
},
"trust": {
"manifestLocation": "/apps/trust/fed-mods.json",
"modules": [
{
"id": "trust",
"module": "./RootApp",
"routes": [
{
"pathname": "/inventory"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a full pathname to the location where the module should be mounted. I don't think /insights is the place. What is the URL to the page where these modules should be available at?

},
{
"pathname": "/package"
}
]
}
]
}
}
11 changes: 11 additions & 0 deletions static/beta/stage/navigation/trust-navigation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"id": "trust",
"title": "Trusted Content",
"navItems": [
{
"title": "Trusted Content",
"appId": "trust",
"href": "/trust"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this URL does not seems correct. The link href should include the module route.

}
]
}