Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated descriptions on Learning Resource cards for Red Hat Insights #288

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

michelle-purcell
Copy link
Contributor

@michelle-purcell michelle-purcell commented Jan 22, 2025

This PR makes edits to fix a truncation issue on 12 Learning Resource cards for Red Hat Insights here.
The issue is tracked in JIRA HCCDOC-3089 Insights bundle: Review & shorten truncated Learning resources tile descriptions.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@michelle-purcell michelle-purcell force-pushed the HCCDOC-3089 branch 6 times, most recently from 73f6e87 to 99a11f0 Compare January 22, 2025 13:57
@florkbr
Copy link
Contributor

florkbr commented Jan 22, 2025

/ok-to-test

@michelle-purcell michelle-purcell force-pushed the HCCDOC-3089 branch 2 times, most recently from 3a94ff7 to 5de1259 Compare January 23, 2025 11:43
@michelle-purcell
Copy link
Contributor Author

florkbr - Thank you so much for reviewing. I fixed the indentation issue in this PR. I think the build will work now.

@Hyperkid123
Copy link
Collaborator

/ok-to-test

@michelle-purcell michelle-purcell force-pushed the HCCDOC-3089 branch 2 times, most recently from 07e7bb9 to 093f75d Compare January 23, 2025 15:09
Copy link
Contributor

@mmcclaingithub mmcclaingithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for a few. Great job synthesizing a lot of information into more usable chunks of text. I don't think any suggestions are must have.

@michelle-purcell michelle-purcell force-pushed the HCCDOC-3089 branch 2 times, most recently from 89c5ba5 to 08dba43 Compare January 23, 2025 19:22
@michelle-purcell
Copy link
Contributor Author

@mmcclaingithub - Thanks so much for doing such a thorough peer review. I applied most of your suggestions.

@michelle-purcell
Copy link
Contributor Author

Hello @florkbr. I made some adjustments following the peer review.
I think I have resolved your comments to fix the build issues, however, I see a new Grype security error. Any ideas? Thank you.

Copy link
Contributor Author

@michelle-purcell michelle-purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florkbr - I think I fixed it. It doesn't see to like the extra line-break that I added. Sorry for the churn.

@michelle-purcell michelle-purcell force-pushed the HCCDOC-3089 branch 2 times, most recently from cd8b88b to 72b66db Compare January 23, 2025 19:33
@michelle-purcell
Copy link
Contributor Author

@florkbr - Thanks for your help so far. Is this PR ready to be merged and pushed to staging?

@florkbr
Copy link
Contributor

florkbr commented Jan 29, 2025

/ok-to-test

red-hat-konflux bot and others added 3 commits January 29, 2025 21:44
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Insights bundle: Review and update tags in metadata.yml files for quickstarts
florkbr and others added 3 commits January 29, 2025 21:44
Scan, detect, monitor, and report malware attacks on systems within a RHEL environment. Utilizes YARA-pattern-matching software and malware-detection signatures.

more changes

fix

fix truncation

fix

fix

fix

build fix

fix

Update docs/quickstarts/insights-console-subscriptions/insights-console-subscriptions.yml

Co-authored-by: mmcclaingithub <[email protected]>

Update docs/quickstarts/insights-centos/insights-centos.yml

Co-authored-by: mmcclaingithub <[email protected]>

peer review fix

fix

Remove bad line
@florkbr
Copy link
Contributor

florkbr commented Jan 30, 2025

/ok-to-test

@florkbr florkbr merged commit 43cbd6b into RedHatInsights:main Jan 30, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants