-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix truncated descriptions on Learning Resource cards for Red Hat Insights #288
Conversation
Can one of the admins verify this patch? |
73f6e87
to
99a11f0
Compare
/ok-to-test |
docs/quickstarts/insights-compliance-reports/insights-compliance-reports.yml
Outdated
Show resolved
Hide resolved
3a94ff7
to
5de1259
Compare
florkbr - Thank you so much for reviewing. I fixed the indentation issue in this PR. I think the build will work now. |
/ok-to-test |
07e7bb9
to
093f75d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for a few. Great job synthesizing a lot of information into more usable chunks of text. I don't think any suggestions are must have.
docs/quickstarts/insights-assess-vulnerabilities/insights-assess-vulnerabilities.yml
Show resolved
Hide resolved
docs/quickstarts/insights-blueprints/insights-creating-blueprint-images.yml
Show resolved
Hide resolved
docs/quickstarts/insights-console-subscriptions/insights-console-subscriptions.yml
Outdated
Show resolved
Hide resolved
docs/quickstarts/insights-patch-remediate/insights-patch-remediate.yml
Outdated
Show resolved
Hide resolved
89c5ba5
to
08dba43
Compare
@mmcclaingithub - Thanks so much for doing such a thorough peer review. I applied most of your suggestions. |
Hello @florkbr. I made some adjustments following the peer review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florkbr - I think I fixed it. It doesn't see to like the extra line-break that I added. Sorry for the churn.
cd8b88b
to
72b66db
Compare
@florkbr - Thanks for your help so far. Is this PR ready to be merged and pushed to staging? |
/ok-to-test |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Insights bundle: Review and update tags in metadata.yml files for quickstarts
…e177abec19b8e94e1a99455
Scan, detect, monitor, and report malware attacks on systems within a RHEL environment. Utilizes YARA-pattern-matching software and malware-detection signatures. more changes fix fix truncation fix fix fix build fix fix Update docs/quickstarts/insights-console-subscriptions/insights-console-subscriptions.yml Co-authored-by: mmcclaingithub <[email protected]> Update docs/quickstarts/insights-centos/insights-centos.yml Co-authored-by: mmcclaingithub <[email protected]> peer review fix fix Remove bad line
99b54b9
to
4b350ba
Compare
/ok-to-test |
This PR makes edits to fix a truncation issue on 12 Learning Resource cards for Red Hat Insights here.
The issue is tracked in JIRA HCCDOC-3089 Insights bundle: Review & shorten truncated Learning resources tile descriptions.