Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Godot v4.3 stable #45

Merged
merged 1 commit into from
Sep 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ensure_build_works.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ jobs:
name: Download Latest Godot
with:
repository: 'godotengine/godot-builds'
fileName: 'Godot_v4.3-beta3_linux.x86_64.zip'
tag: '4.3-beta3'
fileName: 'Godot_v4.3-stable_linux.x86_64.zip'
tag: '4.3-stable'
extract: true
out-file-path: ./build
- name: Make downloaded file executable
run: chmod +x ./build/Godot_v4.3-beta3_linux.x86_64
run: chmod +x ./build/Godot_v4.3-stable_linux.x86_64
- name: Set executable env var
run: echo "GODOT4_BIN=$GITHUB_WORKSPACE/build/Godot_v4.3-beta3_linux.x86_64" >> $GITHUB_ENV
run: echo "GODOT4_BIN=$GITHUB_WORKSPACE/build/Godot_v4.3-stable_linux.x86_64" >> $GITHUB_ENV
- name: Build
working-directory: ./rust
run: cargo build --features custom-godot
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/make_release_files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
name: Download Latest Godot
with:
repository: 'godotengine/godot-builds'
fileName: 'Godot_v4.3-beta3_win64.exe.zip'
tag: '4.3-beta3'
fileName: 'Godot_v4.3-stable_win64.exe.zip'
tag: '4.3-stable'
extract: true
out-file-path: ./build
- name: Set executable env var
run: echo "GODOT4_BIN=$env:GITHUB_WORKSPACE/build/Godot_v4.3-beta3_win64.exe" >> $env:GITHUB_ENV
run: echo "GODOT4_BIN=$env:GITHUB_WORKSPACE/build/Godot_v4.3-stable_win64.exe" >> $env:GITHUB_ENV
- name: Build Debug
working-directory: ./rust
run: cargo build --features custom-godot
Expand Down Expand Up @@ -111,14 +111,14 @@ jobs:
name: Download Latest Godot
with:
repository: 'godotengine/godot-builds'
fileName: 'Godot_v4.3-beta3_linux.x86_64.zip'
tag: '4.3-beta3'
fileName: 'Godot_v4.3-stable_linux.x86_64.zip'
tag: '4.3-stable'
extract: true
out-file-path: ./build
- name: Make downloaded file executable
run: chmod +x ./build/Godot_v4.3-beta3_linux.x86_64
run: chmod +x ./build/Godot_v4.3-stable_linux.x86_64
- name: Set executable env var
run: echo "GODOT4_BIN=$GITHUB_WORKSPACE/build/Godot_v4.3-beta3_linux.x86_64" >> $GITHUB_ENV
run: echo "GODOT4_BIN=$GITHUB_WORKSPACE/build/Godot_v4.3-stable_linux.x86_64" >> $GITHUB_ENV
- name: Build Debug
working-directory: ./rust
run: cargo build --features custom-godot
Expand Down
2 changes: 1 addition & 1 deletion BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ As explained in the [Available Versions](./README.md#forked) section of the read

## Version Compatibility

You must use [Godot v4.3 dev 6](https://godotengine.org/article/dev-snapshot-godot-4-3-dev-6/) or newer.
You must use [Godot v4.3](https://github.com/godotengine/godot/releases/tag/4.3-stable) or newer.

The GDExtension uses following APIs only available in this version:

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ This extension can be downloaded in two different versions, each with their own

### Default

- Works with official releases of [Godot v4.3 dev 6](https://godotengine.org/article/dev-snapshot-godot-4-3-dev-6/) or newer.
- Works with official releases of [Godot v4.3](https://github.com/godotengine/godot/releases/tag/4.3-stable) or newer.
- Available on the [Asset Library](https://godotengine.org/asset-library/asset/2937).
- Has some limitations
- Translations that use variables are written like `tr(TranslationFluent.args("message", { ... }))`
Expand Down Expand Up @@ -60,7 +60,7 @@ This is why you have the choice between a version that has better engine support
- The **Default** version is also available on the [Asset Library](https://godotengine.org/asset-library/asset/2937).
- Extract the zip file contents to your project folder, so that the project root contains an `addons` folder.
- Download a compatible version of Godot.
- **Default**: [Godot v4.3 dev 6](https://godotengine.org/article/dev-snapshot-godot-4-3-dev-6/) or newer.
- **Default**: [Godot v4.3](https://github.com/godotengine/godot/releases/tag/4.3-stable) or newer.
- **Forked**: [Download forked builds here.](https://github.com/RedMser/godot/releases)
- Start Godot editor. If it was already running, restart it to fix autocompletion.
- Follow the sample code to see if installation was successful. Remove any code which contains errors, as some of it only works depending on the version you've installed.
Expand Down