change naming

RequestNetwork · Jan 10, 2025 · 7f36372 · 7f36372
1 parent f68fbff
commit 7f36372
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 34 deletions.
diff --git a/packages/data-access/src/combined-data-access.ts b/packages/data-access/src/combined-data-access.ts
@@ -17,8 +17,8 @@ export abstract class CombinedDataAccess implements DataAccessTypes.IDataAccess
     await this.reader.close();
   }
 
-  isPersisting(): boolean {
-    return !(this.writer instanceof NoPersistDataWrite);
+  skipPersistence(): boolean {
+    return this.writer instanceof NoPersistDataWrite;
   }
 
   async getTransactionsByChannelId(

diff --git a/packages/request-client.js/src/api/request-network.ts b/packages/request-client.js/src/api/request-network.ts
@@ -114,7 +114,7 @@ export default class RequestNetwork {
 
     const transactionData = requestLogicCreateResult.meta?.transactionManagerMeta.transactionData;
     const requestId = requestLogicCreateResult.result.requestId;
-    const isSkippingPersistence = !this.dataAccess.isPersisting();
+    const isSkippingPersistence = this.dataAccess.skipPersistence();
     // create the request object
     const request = new Request(requestId, this.requestLogic, this.currencyManager, {
       contentDataExtension: this.contentData,
@@ -157,7 +157,7 @@ export default class RequestNetwork {
       throw new Error('Cannot persist request without inMemoryInfo.');
     }
 
-    if (!this.dataAccess.isPersisting()) {
+    if (this.dataAccess.skipPersistence()) {
       throw new Error(
         'Cannot persist request when skipPersistence is enabled. To persist the request, create a new instance of RequestNetwork without skipPersistence being set to true.',
       );
@@ -197,7 +197,7 @@ export default class RequestNetwork {
 
     const transactionData = requestLogicCreateResult.meta?.transactionManagerMeta.transactionData;
     const requestId = requestLogicCreateResult.result.requestId;
-    const isSkippingPersistence = !this.dataAccess.isPersisting();
+    const isSkippingPersistence = this.dataAccess.skipPersistence();
 
     // create the request object
     const request = new Request(requestId, this.requestLogic, this.currencyManager, {

diff --git a/packages/request-client.js/src/http-data-access.ts b/packages/request-client.js/src/http-data-access.ts
@@ -21,24 +21,23 @@ export default class HttpDataAccess extends CombinedDataAccess {
     {
       httpConfig,
       nodeConnectionConfig,
-      persist,
+      skipPersistence,
     }: {
       httpConfig?: Partial<ClientTypes.IHttpDataAccessConfig>;
       nodeConnectionConfig?: Partial<NodeConnectionConfig>;
-      persist?: boolean;
+      skipPersistence?: boolean;
     } = {
       httpConfig: {},
       nodeConnectionConfig: {},
-      persist: true,
+      skipPersistence: true,
     },
   ) {
     const dataAccessConfig = new HttpDataAccessConfig({ httpConfig, nodeConnectionConfig });
     const transaction = new HttpTransaction(dataAccessConfig);
     const reader = new HttpDataRead(dataAccessConfig);
-    const writer =
-      persist === false
-        ? new NoPersistDataWrite()
-        : new HttpDataWrite(dataAccessConfig, transaction);
+    const writer = skipPersistence
+      ? new NoPersistDataWrite()
+      : new HttpDataWrite(dataAccessConfig, transaction);
 
     super(reader, writer);
 

diff --git a/packages/request-client.js/src/http-request-network.ts b/packages/request-client.js/src/http-request-network.ts
@@ -57,7 +57,7 @@ export default class HttpRequestNetwork extends RequestNetwork {
   ) {
     const dataAccess: DataAccessTypes.IDataAccess = useMockStorage
       ? new MockDataAccess(new MockStorage())
-      : new HttpDataAccess({ httpConfig, nodeConnectionConfig, persist: !skipPersistence });
+      : new HttpDataAccess({ httpConfig, nodeConnectionConfig, skipPersistence });
 
     if (!currencyManager) {
       currencyManager = CurrencyManager.getDefault();

diff --git a/packages/request-client.js/test/api/request-network.test.ts b/packages/request-client.js/test/api/request-network.test.ts
@@ -16,7 +16,7 @@ const mockDataAccess: DataAccessTypes.IDataAccess = {
   close: jest.fn(),
   persistTransaction: jest.fn(),
   getChannelsByMultipleTopics: jest.fn(),
-  isPersisting: jest.fn().mockReturnValue(true),
+  skipPersistence: jest.fn().mockReturnValue(true),
 };
 
 describe('api/request-network', () => {

diff --git a/packages/transaction-manager/test/index.test.ts b/packages/transaction-manager/test/index.test.ts
@@ -74,7 +74,7 @@ describe('index', () => {
         );
         return fakeMetaDataAccessPersistReturn;
       }),
-      isPersisting: jest.fn().mockReturnValue(true),
+      skipPersistence: jest.fn().mockReturnValue(true),
     };
   });
 
@@ -228,7 +228,7 @@ describe('index', () => {
           initialize: jest.fn(),
           close: jest.fn(),
           persistTransaction: jest.fn().mockReturnValue(fakeMetaDataAccessPersistReturn),
-          isPersisting: jest.fn().mockReturnValue(true),
+          skipPersistence: jest.fn().mockReturnValue(true),
         };
 
         const transactionManager = new TransactionManager(
@@ -275,7 +275,7 @@ describe('index', () => {
           initialize: jest.fn(),
           close: jest.fn(),
           persistTransaction: jest.fn().mockReturnValue(fakeMetaDataAccessPersistReturn),
-          isPersisting: jest.fn().mockReturnValue(true),
+          skipPersistence: jest.fn().mockReturnValue(true),
         };
 
         const transactionManager = new TransactionManager(
@@ -318,7 +318,7 @@ describe('index', () => {
           initialize: jest.fn(),
           close: jest.fn(),
           persistTransaction: jest.fn().mockReturnValue(fakeMetaDataAccessPersistReturn),
-          isPersisting: jest.fn().mockReturnValue(true),
+          skipPersistence: jest.fn().mockReturnValue(true),
         };
 
         const transactionManager = new TransactionManager(
@@ -395,7 +395,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(fakeDataAccess);
@@ -446,7 +446,7 @@ describe('index', () => {
           .mockReturnValue(fakeMetaDataAccessGetReturnFirstHashWrong),
         initialize: jest.fn(),
         close: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
         persistTransaction: jest.fn(),
       };
 
@@ -506,7 +506,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -564,7 +564,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(fakeDataAccess);
@@ -638,7 +638,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -726,7 +726,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -803,7 +803,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -882,7 +882,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -960,7 +960,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -1109,7 +1109,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -1184,7 +1184,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(
@@ -1253,7 +1253,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(fakeDataAccess);
@@ -1333,7 +1333,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(fakeDataAccess);
@@ -1403,7 +1403,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(fakeDataAccess);
@@ -1483,7 +1483,7 @@ describe('index', () => {
         initialize: jest.fn(),
         close: jest.fn(),
         persistTransaction: jest.fn(),
-        isPersisting: jest.fn().mockReturnValue(true),
+        skipPersistence: jest.fn().mockReturnValue(true),
       };
 
       const transactionManager = new TransactionManager(

diff --git a/packages/types/src/data-access-types.ts b/packages/types/src/data-access-types.ts
@@ -36,7 +36,7 @@ export interface IDataWrite {
 }
 
 export interface IDataAccess extends IDataRead, IDataWrite {
-  isPersisting(): boolean;
+  skipPersistence(): boolean;
   _getStatus?(): Promise<IDataAccessStatus>;
   getLitCapacityDelegationAuthSig?: (delegateeAddress: string) => Promise<AuthSig>;
 }