feat(request-node): use subgraph for confirmation #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
kevindavee,
olivier7delf and
yomarion
olivier7delf
approved these changes
Dec 11, 2023
MantisClone
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
This change removes the handling of failed transactions. I think this is acceptable, since there is a relatively short timeout on confirmation, and failures aren't very common. Please feel free to challenge this.
I agree that this is acceptable for now.
I have a suspicion that the Request Node doesn't handle reorgs gracefully, but investigating and fixing it is beyond the scope of this PR.
Nice work 👍
benjlevesque
force-pushed
the
feat/request-node/use-subgraph-for-confirmation
branch
from
f945e8d to
cfbf5b1
Compare
benjlevesque
changed the title
benjlevesque
deleted the
feat/request-node/use-subgraph-for-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1287
Requires RequestNetwork/storage-subgraph#13
This changes removes the handling of failed transactions. I think this is acceptable, since there is a relatively short timeout on confirmation, and failures aren't very common. Please feel free to challenge this.