-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change default dueDate to 30 days #290
chore: change default dueDate to 30 days #290
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)packages/create-invoice-form/src/lib/invoice/form.svelte (3)
The multi-line formatting of the variable initialization enhances code readability.
The modification to set the default due date to 30 days after the issue date is well-implemented and aligns with common invoicing practices. The calculation is accurate using millisecond-based arithmetic.
The formatting improvements in the UI-related code maintain functionality while enhancing code cleanliness. Also applies to: 422-422 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #279
Problem
The current Due Date field defaults to 1 day, which is not aligned with invoicing industry conventions and may lead to confusion or inefficiency for users.
Changes
Summary by CodeRabbit
New Features
Improvements
Bug Fixes