Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change default dueDate to 30 days #290

Merged

Conversation

sstefdev
Copy link
Member

@sstefdev sstefdev commented Dec 20, 2024

Fixes #279

Problem

The current Due Date field defaults to 1 day, which is not aligned with invoicing industry conventions and may lead to confusion or inefficiency for users.

Changes

  • Modified the logic in the web component to set the default Due Date to 30 days.

Summary by CodeRabbit

  • New Features

    • Extended the default due date from 1 day to 30 days after the issued date in the invoice form.
  • Improvements

    • Enhanced clarity in the initialization of settlement currencies.
    • Minor adjustments to the currency dropdown for consistent formatting.
  • Bug Fixes

    • Maintained existing functionality for adding and removing invoice items without any issues.

@sstefdev sstefdev linked an issue Dec 20, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

The pull request introduces modifications to the form.svelte file in the create-invoice-form package. The primary changes include adjusting the initialization of filteredSettlementCurrencies and modifying the dueDate calculation to extend the default duration from one day to thirty days after the invoice issue date. These updates aim to improve code readability and align with invoicing industry conventions for default due date settings.

Changes

File Change Summary
packages/create-invoice-form/src/lib/invoice/form.svelte - Updated filteredSettlementCurrencies variable initialization formatting
- Modified dueDate calculation to default to 30 days instead of 1 day
- Minor adjustments to SearchableDropdown component formatting

Possibly related issues

Possibly related PRs

Suggested reviewers

  • MantisClone

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa6f216 and b1d6c7c.

📒 Files selected for processing (1)
  • packages/create-invoice-form/src/lib/invoice/form.svelte (4 hunks)
🔇 Additional comments (3)
packages/create-invoice-form/src/lib/invoice/form.svelte (3)

32-33: LGTM! Improved readability

The multi-line formatting of the variable initialization enhances code readability.


165-165: LGTM! Due date change aligns with industry standards

The modification to set the default due date to 30 days after the issue date is well-implemented and aligns with common invoicing practices. The calculation is accurate using millisecond-based arithmetic.


410-410: LGTM! Clean formatting changes

The formatting improvements in the UI-related code maintain functionality while enhancing code cleanliness.

Also applies to: 422-422


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sstefdev sstefdev self-assigned this Dec 20, 2024
@sstefdev sstefdev merged commit ec6ca36 into main Dec 20, 2024
2 checks passed
@sstefdev sstefdev deleted the 279-increase-default-due-date-to-30-days-currently-1-day branch December 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase default due date to 30 days (currently 1 day)
2 participants