Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove currencies that fail to create conversion requests #338

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

MantisClone
Copy link
Member

@MantisClone MantisClone commented Feb 6, 2025

Problem

#316

Bandaid Solution

Temporarily remove the failing currencies.

TODO

  • Test locally

Summary by CodeRabbit

  • Chores
    • Updated the default currency options available within the application, streamlining the list for a more focused user experience.
    • Updated the version of the @requestnetwork/create-invoice-form package to 0.13.0.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Walkthrough

This pull request updates the initialization of the currency manager by modifying the defaultCurrencyIds array in shared/utils/initCurrencyManager.ts. Several currency identifiers—specifically, IDs for BSC, Optimism, xDai, and base-related currencies—have been removed, leaving a set primarily consisting of mainnet, Matic, and Sepolia currencies. Additionally, the version of the package @requestnetwork/create-invoice-form has been updated from 0.12.4 to 0.13.0. No changes were made to exported or public entities.

Changes

File Change Summary
shared/utils/initCurrencyManager.ts Removed multiple currency identifiers ("DAI-bsc", "BUSD-bsc", "ETH-base-base", "DAI-optimism", "ETH-optimism-optimism", "USDC-optimism", "USDT-optimism", "USDC-xdai", "USDC-base") from the defaultCurrencyIds array.
packages/create-invoice-form/package.json Updated the version of @requestnetwork/create-invoice-form from 0.12.4 to 0.13.0.

Possibly related PRs

Suggested reviewers

  • rodrigopavezi
  • sstefdev
  • aimensahnoun

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99da430 and bc6abae.

📒 Files selected for processing (1)
  • packages/create-invoice-form/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/create-invoice-form/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MantisClone MantisClone marked this pull request as ready for review February 6, 2025 16:27
@MantisClone MantisClone self-assigned this Feb 6, 2025
Copy link
Member

@rodrigopavezi rodrigopavezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@MantisClone
Copy link
Member Author

MantisClone commented Feb 6, 2025

While testing, I did not see "fUSDC (sepolia)" as a payment currency option after selecting "USD" invoice currency and "sepolia" payment chain.

I don't understand why, but it's not a blocker to merge.

image

@MantisClone
Copy link
Member Author

MantisClone commented Feb 6, 2025

I successfully created requests for all the currencies except the following. Despite being present in the code, the following currencies did not appear as options.

  • REQ-mainnet
  • fUSDC-sepolia

image

@MantisClone MantisClone merged commit 71e1cbc into main Feb 6, 2025
2 checks passed
@MantisClone MantisClone deleted the remove-broken-conversion-currencies branch February 6, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants