Added accessibility header trait to legacy v1 paywall titles. #5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Blind users of my app have taught me that adding the accessibility header trait to a title can help with their navigation of a UI via VoiceOver (since there is a rotor option to jump to headers).
Description
Note: These changes are only for the templates for legacy v1 paywalls.
Inside each of the templates I identified where the paywall title was displayed and added the accessibility header trait to it.
How I Tested
I started using RevenueCat paywalls from the beginning so I have an existing legacy v1 paywall. Currently I have a targeting rule that points users of current versions of my app to use my v2 paywall. To test I created another targeting rule that expires soon. It points users of a build number that only I could have to use legacy paywalls. I verified that VoiceOver properly identified the title as a header with my code changes to the SDK in use.