Replace flaky tests #5969
Open
Replace flaky tests #5969
+97
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lEnterForegroundNotification`)
📸 Snapshot Test1 modified, 240 unchanged
🛸 Powered by Emerge Tools |
Member
Author
|
@RCGitBot please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some integration tests that were flaky because they relied on background tasks that would not have a deterministic behavior and would lead to race conditions. These tests checked the SDK behavior regarding flushing of ad events when certain application notifications happened (e.g.
applicationWillEnterForegroundNotification).Recent failure here.
Description
This PR removes those flaky tests and replaces them with other unit tests that check that the
Purchasesinstance calls (or not) theEventsManager's flush events method as expected.