Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric: use Lucko's Fabric Permssion API #118

Merged
merged 8 commits into from
Dec 29, 2024
Merged

Conversation

CamperSamu
Copy link
Contributor

This is an implementation of what is described in the issue #117.
This PR also updates the module to 1.21.

@CamperSamu
Copy link
Contributor Author

(the force-push was to remove a useless commit related to a non-working fix)

@CamperSamu
Copy link
Contributor Author

I am still testing this, wait before merging

@creatorfromhell
Copy link
Contributor

I am still testing this, wait before merging

You can mark the pr as a draft.

@CamperSamu CamperSamu marked this pull request as draft October 28, 2024 15:00
@Revxrsal
Copy link
Owner

Status?

@CamperSamu
Copy link
Contributor Author

@Revxrsal Tomorrow I should get some time to work on this.

@CamperSamu CamperSamu marked this pull request as ready for review December 27, 2024 17:27
@CamperSamu
Copy link
Contributor Author

I've added a test mod for Fabric.
I've tested the behavior of the new Permission API with and without LuckPerms and it fallbacks to Vanilla correctly.
The default Vanilla permission level is 4 (OP), while it is required to include a permission string for good practice so that if a server has luckperms permissions are available.
If required, a command can be marked as available by default by setting the Vanilla level to 0.

@Revxrsal Revxrsal merged commit de15e2f into Revxrsal:v4 Dec 29, 2024
1 of 2 checks passed
@Revxrsal
Copy link
Owner

Revxrsal commented Dec 29, 2024

Thanks! I've merged it. What's the least supported version of Fabric though after this update?

@CamperSamu
Copy link
Contributor Author

CamperSamu commented Jan 7, 2025

No problem, sorry for the delays and general slowness but life is getting me hard...
The supported version by the lib is now 1.21, but I think that something can be worked to bring a 1.8 - 1.21.4 support window via Forgix or by using the same trick that ViaVersion uses.

I'd love to work on it but I really don't know if I'll get the time to build something stable.
What I can advise is to keep the Fabric version always updated to latest.

@Revxrsal
Copy link
Owner

Revxrsal commented Jan 7, 2025

I'm not interested in maintaining Fabric support for versions older than 1.20 anyway, so I'm fine with its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants