Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update naming conventions for settings object #60

Open
bzkrouse opened this issue Apr 18, 2017 · 1 comment
Open

Update naming conventions for settings object #60

bzkrouse opened this issue Apr 18, 2017 · 1 comment
Milestone

Comments

@bzkrouse
Copy link

Update chart arguments to be consistent with naming conventions of other safety charts. Keep support of previous argument names until next major release. This includes the following changes:

id -> id_col
major -> major_col
minor -> minor_col
group -> group_col
placeholderFlag -> missingValues
totalCol -> showTotalCol
diffCol -> showDiffCol
prefTerms -> showPrefTerms

@jwildfire jwildfire added this to the v4.0.0 milestone Aug 21, 2018
@jwildfire
Copy link
Contributor

Probably just going to want to hold off on this until v4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants