Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add runtime to ffi::listen #512

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

RyanKung
Copy link
Member

@RyanKung RyanKung commented Jan 2, 2024

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bugfix

🟤 What is the current behavior? (You can also link to an open issue here)

  1. async listen needs tokio runtime

🟢 What is the new behavior (if this is a feature change)?

added runtime to listen, rm async_listen, for now ffi::listen is default as async

☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

ℹ️ Other information

Closes #issue

@RyanKung RyanKung merged commit ccfe2cf into master Jan 2, 2024
5 checks passed
@RyanKung RyanKung deleted the feat_add_runtime_to_listner branch March 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant