Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy for assets dir introduced in playwright 1.32 #3

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix copy for assets dir introduced in playwright 1.32 #3

merged 1 commit into from
Apr 5, 2023

Conversation

nil1511
Copy link
Contributor

@nil1511 nil1511 commented Mar 25, 2023

Fixes #2

@MindaugasMateika
Copy link

Can this be merged @anooprav7 and released?

@nil1511
Copy link
Contributor Author

nil1511 commented Mar 28, 2023

@MindaugasMateika I have published this package at @nil1511/playwright-merge-html-reports with this PR, as it was a blocker for me.

@costa-collibra
Copy link

@nil1511 can i get access to the published package with the fix in?

@nil1511
Copy link
Contributor Author

nil1511 commented Mar 29, 2023

It is public on https://www.npmjs.com/package/@nil1511/playwright-merge-html-reports
install that and replace the import
eg. require("playwright-merge-html-reports"); to require("@nil1511/playwright-merge-html-reports");

@costa-collibra
Copy link

@nil1511 thanks

@aaron-smits
Copy link

Thank you for your work @nil1511 !

@ajssd
Copy link

ajssd commented Apr 4, 2023 •
edited
Loading

@anooprav7 When will this fix appear in a new released version, so we can move to Playwright 1.32.x without having to change dependencies?

anooprav7
anooprav7 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@anooprav7 anooprav7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anooprav7 anooprav7 merged commit 9a2cd5f into Rippling:main Apr 5, 2023
@nil1511 nil1511 deleted the patch-1 branch April 5, 2023 15:00
@anooprav7
Copy link
Collaborator

This is published - https://www.npmjs.com/package/playwright-merge-html-reports/v/0.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooprav7 anooprav7 anooprav7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging does not work with Playwright 1.32.0
6 participants
@nil1511 @MindaugasMateika @costa-collibra @aaron-smits @ajssd @anooprav7