-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update todo-progress-bar.json #965
Conversation
Update todo-progress-bar.json Update todo-progress-bar.json
Here’s your link to the diff: Changed 8bitgentleman/todo-progress-bar bd8b65a → cc28bb7 (PR-shorthand: |
Hey @8bitgentleman, my review below: 1. Main issue I see is that this change changes the uid of the blocks, both the code and css blocks For example, the What effect would that have on the old code blocks from before this release? 2. (Optional but would be good to have) I think @tombarys and I ran into a better way of setting-up/tearing-down extensions which have roam render components. Could you take a look? The new radial view looks nicee btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s your link to the diff: Changed 8bitgentleman/todo-progress-bar bd8b65a → 3d45684 (PR-shorthand: |
@baibhavbista thanks for catching this!! The uid change was definitely accidental. I've also made the load/unload updates mentioned (I believe). I tested and it seemed to work |
@8bitgentleman thanks |
adds an option for both horizontal progress bars as well as radial progress bars
Just pass in "radial" to the component to try
{{[[roam/render]]:((roam-render-todo-progress-bar-cljs)) "radial"}}