-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update Live AI Assistant #992
Major update Live AI Assistant #992
Conversation
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 6cd5e16 (PR-shorthand: |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 6cd5e16 (PR-shorthand: |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 61a61dc (PR-shorthand: |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 61a61dc (PR-shorthand: |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 00b14d8 (PR-shorthand: |
This is very cool! The natural language roam query works very well for me, I actually built this awhile ago and never shipped it but yours works much better than mine did. The Smart Search Agent does crash the page with OOM for me sometimes (not all the time) on a large graph (the graph takes up about 1GB of RAM normally and spikes to 4GB when running smart search). It's also pretty slow. Ask my graph is also slow but haven't noticed it crash my graph yet. The extension is a little too large for me to fully understand it but I did notice in some places you use descendant rules These can be really really slow compared to doing a recursive pull. If smart search uses this you could try replacing it with pulls if possible. You can also use :block/parents to search children / parents in datalog queries I also wonder if you could replace some of the queries you are doing for a Roam Query, I could expose a frontend API endpoint to execute Roam Queries, and I have been thinking about adding regex search to this as well. |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 00b14d8 (PR-shorthand: |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 204bee5 (PR-shorthand: |
I've just fixed the small issue when no API key. Yes, Smart Search Agent (and Ask to my graph... since, it's using the same search engine) rely on recursive descendant rules (if search is not limited to 2 children levels or less). |
Frontend API for Roam queries would also be a great solution |
I think it's fine to publish even if it crashes someone's graph, just making suggestions for the future. In that respect I'd actually be more worried that the datomic one would generate a query which crashes the graph because reloading wouldn't fix that, but we will figure something out on our end for that If you think roam queries could replace it then hold off on optimizing for pull, I can work on that next week |
Yes, i think that o3-mini require to be minimum tier 3 currently. I should add something in readme about that. |
Is there anyway I can use other openAI models like o1 preview or mini? I think I'm on usage tier 2 which would allow for that |
It should be possible for o1-mini and o1-preview since it's tier 1+ . I can't test because i'm tier 3. |
Here’s your link to the diff: Changed fbgallet/roam-extension-speech-to-roam 8d47567 → 8358dda (PR-shorthand: |
I've pushed a version limited to 2 children levels, without recursive rule, and also removed sibling search temporarily. I would prefer to first test a version that seems more stable. o3-mini is working for me, i suppose that there is some delay after accessing to a new tier. |
retested smart search and none of the queries which crashed my graph crash it anymore |
On my side, it's ready for publication, I've still some additionnal doc to write, but not in Readme.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright this seems good to me to merge now
Note that source repo has change from 'https://github.com/fbgallet/roam-extension-speech-to-roam.git' to 'https://github.com/fbgallet/roam-extension-live-ai-assistant.git'
This is a big update, with a lot of new features and refactoring (see beginning of the readme for main new features)
All functions that directly use the Roam API are in principle gathered here: https://github.com/fbgallet/roam-extension-live-ai-assistant/blob/main/src/utils/roamAPI.js
There are two "sensitive" features:
I've made a lot of tests and will continue to test it. It's in principle ready for production but need some small changes in the readme.md.