Skip to content

Commit

Permalink
Rename topic to fit convention
Browse files Browse the repository at this point in the history
  • Loading branch information
jvogt23 committed Jan 28, 2025
1 parent 4030e05 commit 18ac7b9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ RobotFactoryPosition::RobotFactoryPosition(int r_id) : Position(r_id, "RobotFact
std::string node_name{"robot_factory_position_"};
_node = std::make_shared<rclcpp::Node>(node_name.append(std::to_string(robot_id_)));
override_play_sub_ = _node->create_subscription<rj_msgs::msg::OverridePosition>(
"override_position_for_robot_" + std::to_string(robot_id_), 1,
"override_position/robot_" + std::to_string(robot_id_), 1,
[this](const rj_msgs::msg::OverridePosition::SharedPtr msg) { test_play_callback(msg); });

Check warning on line 23 in soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp

View workflow job for this annotation

GitHub Actions / build-and-test

the const qualified parameter 'msg' is copied for each invocation; consider making it a reference
_executor.add_node(_node);
_executor_thread = std::thread([this]() { _executor.spin(); });
Expand Down
2 changes: 1 addition & 1 deletion soccer/src/soccer/ui/main_window.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ MainWindow::MainWindow(Processor* processor, bool has_external_ref, QWidget* par
// Publishers to signal when a manual position override is occurring
for (int i = 0; i < 16; ++i) {
override_play_pubs_.push_back(_node->create_publisher<rj_msgs::msg::OverridePosition>(
"override_position_for_robot_" + std::to_string(i), 1));
"override_position/robot_" + std::to_string(i), 1));
}

_executor.add_node(_node);
Expand Down

0 comments on commit 18ac7b9

Please sign in to comment.