Position FSM #2173
Merged
Position FSM #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sid-parikh
requested changes
Jan 29, 2024
| // This is where the current_position can be reassigned based on the | ||
| // PlayState | ||
| // If keeper, make no changes | ||
| if (robot_id_ == 0) { |
There was a problem hiding this comment.
you can't assume 0 is the robot id. you need to get that information from the referee. If i'm not mistaken, there is already a mechanism for AAC to pass this information to its Position. if not, let's figure out how to add it.
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp
Outdated
Show resolved
Hide resolved
automated style fixes Co-authored-by: rishiso <[email protected]>
…on.cpp Co-authored-by: Sid Parikh <[email protected]>
sid-parikh
approved these changes
Jan 31, 2024
|
your last commit says (not finished) so I'm not hitting merge, but feel free to push it if you're done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements position management automatically based on states of the game. Positions used to be static (3 defense, 2 offense, 1 goalie), but now they change dynamically.
Associated / Resolved Issue
ClickUp card
Steps to Test
Run in sim and move the ball to different halves. The positions of robots should change dynamically.
Key Files to Review
Review Checklist