ignore goalie in has_open_shot #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksherling
reviewed
Mar 4, 2024
| rj_geometry::Point enemy_vec = enemy.pose.position() - ball_position; | ||
|
|
||
| // I think this means enemy is behind shot (sid) |
rishiso
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking the goalie into account makes us deny every shot. Let's assume corner shots can evade the goalie, and only take into account defenders. Important to shoot more.
Associated / Resolved Issue
Resolves clickup card: https://app.clickup.com/t/86azgzx41
Steps to Test
In sim:
Result: Shot still taken
Result: Pass instead
Key Files to Review
offense.*pp